FIX trigger condition of one part of a warning from check_feature_names (scikit-learn#23091)

avm19 · jjerphan · commit e1fbbdb7719a · 2022-04-29T14:06:36.000+02:00
diff --git a/sklearn/base.py b/sklearn/base.py
@@ -485,7 +485,7 @@ def add_names(names):
                 message += "Feature names seen at fit time, yet now missing:\n"
                 message += add_names(missing_names)
 
-            if not missing_names and not missing_names:
+            if not missing_names and not unexpected_names:
                 message += (
                     "Feature names must be in the same order as they were in fit.\n"
                 )

Original file line number	Diff line number	Diff line change
`@@ -485,7 +485,7 @@ def add_names(names):`
`485`	`485`	`message += "Feature names seen at fit time, yet now missing:\n"`
`486`	`486`	`message += add_names(missing_names)`
`487`	`487`
`488`		`- if not missing_names and not missing_names:`
	`488`	`+ if not missing_names and not unexpected_names:`
`489`	`489`	`message += (`
`490`	`490`	`"Feature names must be in the same order as they were in fit.\n"`
`491`	`491`	`)`