Skip to content

Fix parseFloat input string length calculation #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2020
Merged

Fix parseFloat input string length calculation #3782

merged 1 commit into from
May 25, 2020

Conversation

@galpeter
Copy link
Contributor

@galpeter galpeter commented May 22, 2020

Fixes: #3778

@galpeter
Fix parseFloat input string length calculation
88b5a0d 
JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
@galpeter galpeter added the bug Undesired behaviour label May 22, 2020
rerobika
rerobika approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dbatyai
dbatyai approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit 6fe6dab into jerryscript-project:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbatyai dbatyai dbatyai approved these changes

@rerobika rerobika rerobika approved these changes

Assignees

No one assigned

Labels

bug Undesired behaviour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

heap-buffer-overflow in ecma_number_parse_float

3 participants

@galpeter @dbatyai @rerobika