Skip to content

Conversation

@rerobika
Copy link
Member

Related part of the standard: https://www.ecma-international.org/ecma-262/5.1/#sec-8.7 1st note.

This patch fixes #2914.

Co-authored-by: Gabor Loki [email protected]
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

@rerobika rerobika added bug Undesired behaviour interpreter Related to the virtual machine labels Jun 19, 2019
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…e base cannot be extensible

Related part of the standard: https://www.ecma-international.org/ecma-262/5.1/#sec-8.7 1st note.

This patch fixes jerryscript-project#2914.

Co-authored-by: Gabor Loki [email protected]
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]
Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rerobika rerobika merged commit 44b21de into jerryscript-project:master Jun 24, 2019
@rerobika rerobika deleted the issue_2914 branch June 16, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour interpreter Related to the virtual machine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An error should be thrown when defining a property for a read-only variable in strict mode.

3 participants