Update JerryScript submodule to post 2.3 version #1949
Conversation
cmake/iotjs.cmake
Outdated
| message(STATUS "JERRY_MEM_STATS ${FEATURE_MEM_STATS}") | ||
| message(STATUS "JERRY_PROFILE ${FEATURE_PROFILE}") | ||
| message(STATUS "JERRY_DEBUGGER ${JERRY_DEBUGGER}") | ||
| message(STATUS "JERRY_HEAP_SIZE_KB ${JERRY_GLOBAL_HEAP_SIZE}") |
There was a problem hiding this comment.
Is this intentionally inconsistent? JERRY_HEAP_SIZE_KB vs JERRY_GLOBAL_HEAP_SIZE
There was a problem hiding this comment.
At the moment I did not want to break the defines/options provided by IoT.js, but I think the name(s) should be normalized in a later change.
There was a problem hiding this comment.
Hm, what I mean is that the name that is printed is not the actual name of the variable that's printed. Shouldn't this be message(STATUS "JERRY_GLOBAL_HEAP_SIZE ${JERRY_GLOBAL_HEAP_SIZE}")?
There was a problem hiding this comment.
Ahh sorry (was confused by the macro names), true . The original one was also misnamed, but it makes sense to use it the way you mentioned.
tools/build.py
Outdated
| help='Enable JerryScript heap statistics') | ||
| jerry_group.add_argument('--jerry-profile', | ||
| metavar='FILE', action='store', default='es5.1', | ||
| metavar='FILE', action='store', default='es.next', |
There was a problem hiding this comment.
Open question: shall the bump to JerryScript 2.3 also include a bump in the supported ES version?
There was a problem hiding this comment.
Ohh. I've missed this. I've just wanted to change the comment below. Will update this asap to keep it at es5.1 for now.
galpeter
force-pushed
the
jerry_update_v2.3
branch
from
78c58b8 to
74bb546
Compare
Based on: jerryscript-project#1933 Original author IoT.js-DCO-1.0-Signed-off-by: bence gabor kis [email protected] IoT.js-DCO-1.0-Signed-off-by: Peter Gal [email protected]
galpeter
force-pushed
the
jerry_update_v2.3
branch
from
74bb546 to
7d18258
Compare
|
@akosthekiss thanks for the input I've updated the PR. |
|
For the record this change fixes this vulnerability: |
4 participants
Based on: #1933
Original author IoT.js-DCO-1.0-Signed-off-by: bence gabor kis [email protected]