Updated JerryScript submodule to 2.1. #1933
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisbg
force-pushed
the
update-jerry
branch
2 times, most recently
from
9ea66a2 to
70b4626
Compare
kisbg
changed the title
kisbg
force-pushed
the
update-jerry
branch
2 times, most recently
from
7cf4c87 to
d801660
Compare
DanielBallaSZTE
suggested changes
Nov 4, 2019
| "required-modules": [ | ||
| "napi" | ||
| "skip": [ | ||
| "all" |
Contributor
There was a problem hiding this comment.
Could you also add a reason for the skip?
kisbg
force-pushed
the
update-jerry
branch
8 times, most recently
from
64735a8 to
2767095
Compare
rtakacs
reviewed
Nov 5, 2019
tools/travis_script.py
Outdated
|
|
||
| for buildtype in BUILDTYPES: | ||
| # The .bss section size is greather than the sram of STM32 board. | ||
| continue |
Contributor
There was a problem hiding this comment.
Interesting approach to skip the for loop. Instead, could we just return before the for loop, and leave a TODO comment to investigate the NuttX binary image?
kisbg
force-pushed
the
update-jerry
branch
2 times, most recently
from
a3b8afc to
957b36d
Compare
rerobika
reviewed
Nov 6, 2019
test/testsets.json
Outdated
| "name": "test_napi_object_wrap.js", | ||
| "required-modules": [ | ||
| "napi" | ||
| "reason": "jerry api usage in native pointer free cb is not supported anymore", |
test/testsets.json
Outdated
| "name": "test_napi_reference.js", | ||
| "required-modules": [ | ||
| "napi" | ||
| "reason": "jerry api usage in native pointer free cb is not supported anymore", |
Contributor
|
This patch breaks some features. What are the benefits of this PR? I think the broken features should be fixed before merge. |
Member
|
Strictly speaking it is not breaking any features, just checks rules which was not checked before and throws correct errors accordingly. In the future we need to think about supporting these use-cases, but that requires new features. |
Contributor
|
Neither STM32 build nor NAPI reference won't work after this patch, so it is definitely breaking features. |
kisbg
force-pushed
the
update-jerry
branch
4 times, most recently
from
5018d62 to
2fe331e
Compare
Contributor
|
@kisbg There are still incorrect |
kisbg
force-pushed
the
update-jerry
branch
2 times, most recently
from
f560bad to
a403c94
Compare
kisbg
force-pushed
the
update-jerry
branch
14 times, most recently
from
d2eabec to
273e140
Compare
Contributor
|
@kisbg Almost ok for me. Could you move the |
kisbg
force-pushed
the
update-jerry
branch
2 times, most recently
from
c1caec2 to
ffbcadc
Compare
Temporary disabled the N-api and STM board travis test-cases. IoT.js-DCO-1.0-Signed-off-by: bence gabor kis [email protected]
galpeter
added a commit
to galpeter/iotjs
that referenced
this pull request
Jul 27, 2020
Based on: jerryscript-project#1933 Original author IoT.js-DCO-1.0-Signed-off-by: bence gabor kis [email protected] IoT.js-DCO-1.0-Signed-off-by: Peter Gal [email protected]
galpeter
added a commit
to galpeter/iotjs
that referenced
this pull request
Jul 27, 2020
Based on: jerryscript-project#1933 Original author IoT.js-DCO-1.0-Signed-off-by: bence gabor kis [email protected] IoT.js-DCO-1.0-Signed-off-by: Peter Gal [email protected]
galpeter
added a commit
to galpeter/iotjs
that referenced
this pull request
Jul 29, 2020
Based on: jerryscript-project#1933 Original author IoT.js-DCO-1.0-Signed-off-by: bence gabor kis [email protected] IoT.js-DCO-1.0-Signed-off-by: Peter Gal [email protected]
galpeter
added a commit
to galpeter/iotjs
that referenced
this pull request
Jul 29, 2020
Based on: jerryscript-project#1933 Original author IoT.js-DCO-1.0-Signed-off-by: bence gabor kis [email protected] IoT.js-DCO-1.0-Signed-off-by: Peter Gal [email protected]
galpeter
added a commit
to galpeter/iotjs
that referenced
this pull request
Jul 29, 2020
Based on: jerryscript-project#1933 Original author IoT.js-DCO-1.0-Signed-off-by: bence gabor kis [email protected] IoT.js-DCO-1.0-Signed-off-by: Peter Gal [email protected]
galpeter
added a commit
to galpeter/iotjs
that referenced
this pull request
Jul 30, 2020
Based on: jerryscript-project#1933 Original author IoT.js-DCO-1.0-Signed-off-by: bence gabor kis [email protected] IoT.js-DCO-1.0-Signed-off-by: Peter Gal [email protected]
galpeter
added a commit
to galpeter/iotjs
that referenced
this pull request
Jul 30, 2020
Based on: jerryscript-project#1933 Original author IoT.js-DCO-1.0-Signed-off-by: bence gabor kis [email protected] IoT.js-DCO-1.0-Signed-off-by: Peter Gal [email protected]
zherczeg
pushed a commit
that referenced
this pull request
Aug 3, 2020
Based on: #1933 Original author IoT.js-DCO-1.0-Signed-off-by: bence gabor kis [email protected] IoT.js-DCO-1.0-Signed-off-by: Peter Gal [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IoT.js-DCO-1.0-Signed-off-by: bence gabor kis [email protected]