Improve logging of path errors.

Author: uhafner

plugin/src/main/java/io/jenkins/plugins/coverage/metrics/source/SourceCodePainter.java

@@ -222,8 +222,6 @@ private Optional<FilePath> findSourceFile(final FilePath workspace, final String
                 if (relativePath.exists()) {
                     return Optional.of(relativePath);
                 }
-
-                log.logError("Source file '%s' not found", fileName);
             }
             catch (InvalidPathException | IOException | InterruptedException exception) {
                 log.logException(exception, "No valid path in coverage node: '%s'", fileName);

plugin/src/main/java/io/jenkins/plugins/coverage/metrics/steps/PathResolver.java

@@ -105,7 +105,7 @@ static class AgentPathResolver extends MasterToSlaveFileCallable<RemoteResultWra
         @Override
         public RemoteResultWrapper<HashMap<String, String>> invoke(
                 final File workspaceFile, final VirtualChannel channel) {
-            FilteredLog log = new FilteredLog("-");
+            FilteredLog log = new FilteredLog("Errors while resolving source files on agent:");
 
             Set<String> sourceDirectories = filterSourceDirectories(workspaceFile, log);
             if (sourceDirectories.isEmpty()) {
@@ -169,7 +169,7 @@ private Optional<String> locateSource(final String relativePath, final FilePath
                     }
                 }
 
-                log.logError("Source file '%s' not found", relativePath);
+                log.logError("- Source file '%s' not found", relativePath);
             }
             catch (InvalidPathException | IOException | InterruptedException exception) {
                 log.logException(exception, "No valid path in coverage node: '%s'", relativePath);
@@ -189,7 +189,7 @@ private Optional<String> enforcePermissionFor(final FilePath absolutePath, final
                     return Optional.of(PATH_UTIL.getAbsolutePath(fileName));
                 }
             }
-            log.logError("Skipping resolving of file: %s (not part of workspace or permitted source code folders)",
+            log.logError("- Skipping resolving of file: %s (not part of workspace or permitted source code folders)",
                     fileName);
             return Optional.empty();
         }

plugin/src/test/java/io/jenkins/plugins/coverage/metrics/source/SourceCodeITest.java

@@ -93,7 +93,8 @@ void coveragePluginPipelineNotRegisteredSourceCodeDirectory() throws IOException
                 .contains("-> finished painting (0 files have been painted, 1 files failed)")
                 .contains(String.format(
                         "[-ERROR-] Removing source directory '%s' - it has not been approved in Jenkins' global configuration.",
-                        sourceDirectory));
+                        sourceDirectory))
+                .contains("- Source file '" + ACU_COBOL_PARSER_SOURCE_FILE_PATH + "' not found");
 
         verifySourceCodeInBuild("", firstBuild, NO_SOURCE_CODE, NO_SOURCE_CODE); // should be still available
         localAgent.setLabelString("<null>");