Commit fbed4e9
authored
fix: use JSON kind for devcontainer updatecli targets (#1846)
* fix: use JSON kind for devcontainer updatecli targets
Switch from file kind with regex patterns to json kind with JSONPath
queries for updating Docker and GitHub CLI versions in devcontainer.json.
The previous file-based approach failed because the search pattern matched
the feature name line, but the version field is on the next line. Using
json kind with JSONPath directly targets the correct fields.
* fix: use bracket notation for JSONPath keys with special characters
* fix: use yaml kind instead of json kind for devcontainer.json
JSON is valid YAML, and updatecli's yaml kind uses yq which handles
bracket notation better than the json kind's JSONPath implementation.
* fix: use file kind with content blocks for devcontainer updates
Use content parameter to identify the specific feature block, then apply
version pattern matching within that block. This avoids JSONPath/yamlpath
syntax issues with keys containing special characters.
* fix: disable devcontainer updatecli manifest temporarily
Disable the devcontainer dependency update pipeline due to updatecli
limitations with JSON keys containing special characters (dots, slashes,
colons). Multiple approaches were attempted (json kind, yaml kind, file
kind with content blocks) but all failed.
Added README explaining the issue and manual update process until a
solution is found.
* fix: move disabled devcontainer manifest outside updatecli.d
Updatecli loads all .yaml files in updatecli.d/ directory, including
.disabled files. Move the disabled devcontainer manifest and its README
to updatecli/disabled/ directory to prevent it from being loaded.1 parent a98986a commit fbed4e9
2 files changed
+46
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
File renamed without changes.
0 commit comments