[CS2] Fix #3098: Suppressed newline should be unsuppressed by semicolon #4669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vendethiel
reviewed
Aug 30, 2017
| @exportSpecifierList = no | ||
|
|
||
| if value is ';' | ||
| @error 'unexpected ;' if prev?[0] in ['=', UNFINISHED...] |
Collaborator
There was a problem hiding this comment.
do we not want = in UNFINISHED?
Collaborator
There was a problem hiding this comment.
or maybe the other way around: what does adding in UNFINISHED fixes, given that prev?[0] is '=' is the relevant fix here? Same in suppressSemicolons.
Collaborator
Author
There was a problem hiding this comment.
See #3098 (comment)
UNFINISHED covers all the similar tokens like += etc. I think @jashkenas in his comment was worried about the special cases around =, like =(newline)(object literal).
Collaborator
Author
There was a problem hiding this comment.
Also, putting = into UNFINISHED causes tests to fail.
# Conflicts: # lib/coffeescript/lexer.js
This was referenced Sep 1, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3098. Now an error is thrown if a semicolon follows an
=or anything in theUNFINISHEDgroup of tokens. No tests fail as a result of this PR, so presumably this isn’t a breaking change (aside from the case ofa = ; 5which we want to throw an error).