Windows use local ccache

Author: hiento09

.github/workflows/quality-gate.yml

@@ -16,7 +16,7 @@ jobs:
             name: "cuda-12-2"
             runs-on: "windows-tensorrt-llm-cuda-12-2"
             run-e2e: false
-            s3-key-prefix: "windows-tensorrt-llm-local-cache"
+            s3-key-prefix: "windows-tensorrt-llm-ccache"
             sccache-conf-path: 'C:\sccache.conf'
           - os: "linux"
             name: "cuda-12-3"
@@ -37,7 +37,7 @@ jobs:
       - name: Install choco on Windows
         if: runner.os == 'Windows'
         run: |
-          choco install make pkgconfiglite sccache awscli -y
+          choco install make pkgconfiglite ccache awscli -y
 
       - name: create sccache.conf file Linux
         if: runner.os == 'Linux'
@@ -50,12 +50,13 @@ jobs:
           echo 'server_side_encryption = false' >> ${{ matrix.sccache-conf-path }}
           echo 'no_credentials = false' >> ${{ matrix.sccache-conf-path }}
       
-      - name: Download sccache for windows
+      - name: Download ccache from s3
+        continue-on-error: true
         if: runner.os == 'Windows'
         run: |
           Import-Module "$env:ChocolateyInstall\helpers\chocolateyProfile.psm1"
           refreshenv
-          aws s3 cp s3://${{ secrets.MINIO_BUCKET_NAME }}/${{ matrix.s3-key-prefix }} C:\Users\ContainerAdministrator\AppData\Local\Mozilla\sccache\cache --recursive --endpoint ${{ secrets.MINIO_ENDPOINT }}
+          aws s3 cp s3://${{ secrets.MINIO_BUCKET_NAME }}/${{ matrix.s3-key-prefix }} C:\Users\ContainerAdministrator\AppData\Local\ccache --recursive --endpoint ${{ secrets.MINIO_ENDPOINT }}
         env:
           AWS_ACCESS_KEY_ID: "${{ secrets.MINIO_ACCESS_KEY_ID }}"
           AWS_SECRET_ACCESS_KEY: "${{ secrets.MINIO_SECRET_ACCESS_KEY }}"
@@ -79,12 +80,12 @@ jobs:
           AWS_SECRET_ACCESS_KEY: "${{ secrets.MINIO_SECRET_ACCESS_KEY }}"
           SCCACHE_IDLE_TIMEOUT: "0"
 
-      - name: start sccache server for windows
-        if: runner.os == 'Windows'
-        run: |
-          sccache --start-server
-        env:
-          SCCACHE_IDLE_TIMEOUT: "0"
+      # - name: start sccache server for windows
+      #   if: runner.os == 'Windows'
+      #   run: |
+      #     sccache --start-server
+      #   env:
+      #     SCCACHE_IDLE_TIMEOUT: "0"
 
       - name: Build Dependencies
         working-directory: cpp
@@ -103,4 +104,16 @@ jobs:
           sccache --stop-server
           rm ${{ matrix.sccache-conf-path }}
 
+      - name: Upload ccache to s3
+        continue-on-error: true
+        if: always() && runner.os == 'Windows'
+        run: |
+          Import-Module "$env:ChocolateyInstall\helpers\chocolateyProfile.psm1"
+          refreshenv
+          aws s3 cp C:\Users\ContainerAdministrator\AppData\Local\ccache s3://${{ secrets.MINIO_BUCKET_NAME }}/${{ matrix.s3-key-prefix }} --recursive --endpoint ${{ secrets.MINIO_ENDPOINT }}
+        env:
+          AWS_ACCESS_KEY_ID: "${{ secrets.MINIO_ACCESS_KEY_ID }}"
+          AWS_SECRET_ACCESS_KEY: "${{ secrets.MINIO_SECRET_ACCESS_KEY }}"
+          AWS_DEFAULT_REGION: "${{ secrets.MINIO_REGION }}"
+
 

cpp/Makefile

@@ -24,7 +24,7 @@ endif
 # Build the Cortex engine
 build:
 ifeq ($(OS),Windows_NT)
-	@powershell -Command "mkdir -p build; cd build; cmake -GNinja -DCMAKE_MSVC_DEBUG_INFORMATION_FORMAT=Embedded -DCMAKE_POLICY_CMP0141=NEW -DCMAKE_CXX_COMPILER_LAUNCHER=sccache -DCMAKE_C_COMPILER_LAUNCHER=sccache -DCMAKE_CUDA_COMPILER_LAUNCHER=sccache -DCMAKE_BUILD_TYPE='Release' -DBUILD_PYT='OFF' -DBUILD_PYBIND='OFF' -DNVTX_DISABLE='ON' -DCMAKE_CUDA_ARCHITECTURES='80-real;86-real;89-real' '-DENABLE_MULTI_DEVICE=0' '-DCMAKE_CUDA_COMPILER=C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v12.2/bin/nvcc.exe' -DBUILD_BENCHMARKS=OFF '-DBUILD_TESTS=OFF' -DTRT_LIB_DIR=C:/workspace/TensorRT-9.3.0.1//lib -DTRT_INCLUDE_DIR=C:/workspace/TensorRT-9.3.0.1//include  ..; cmake --build . --config Release -j1;"
+	@powershell -Command "mkdir -p build; cd build; cmake -GNinja -DCMAKE_MSVC_DEBUG_INFORMATION_FORMAT=Embedded -DCMAKE_POLICY_CMP0141=NEW -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CUDA_COMPILER_LAUNCHER=ccache -DCMAKE_BUILD_TYPE='Release' -DBUILD_PYT='OFF' -DBUILD_PYBIND='OFF' -DNVTX_DISABLE='ON' -DCMAKE_CUDA_ARCHITECTURES='80-real;86-real;89-real' '-DENABLE_MULTI_DEVICE=0' '-DCMAKE_CUDA_COMPILER=C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v12.2/bin/nvcc.exe' -DBUILD_BENCHMARKS=OFF '-DBUILD_TESTS=OFF' -DTRT_LIB_DIR=C:/workspace/TensorRT-9.3.0.1//lib -DTRT_INCLUDE_DIR=C:/workspace/TensorRT-9.3.0.1//include  ..; cmake --build . --config Release -j2;"
 else
 	@mkdir -p build && cd build; \
 	cmake .. -GNinja -DCMAKE_CXX_COMPILER_LAUNCHER=sccache -DCMAKE_C_COMPILER_LAUNCHER=sccache -DCMAKE_CUDA_COMPILER_LAUNCHER=sccache -DCMAKE_BUILD_TYPE='Release' -DBUILD_PYT='OFF' -DBUILD_PYBIND='OFF' -DNVTX_DISABLE='ON' -DCMAKE_CUDA_ARCHITECTURES='80-real;86-real;89-real' '-DENABLE_MULTI_DEVICE=0' '-DCMAKE_CUDA_COMPILER=/usr/local/cuda/bin/nvcc' -DBUILD_BENCHMARKS=OFF '-DBUILD_TESTS=OFF' -DTRT_LIB_DIR=/usr/local/tensorrt/lib -DTRT_INCLUDE_DIR=/usr/local/tensorrt/include; \