From abb5d7f43a202e75bf449fbe0489f28238f5c2fb Mon Sep 17 00:00:00 2001 From: Thuandz Date: Thu, 26 Sep 2024 00:46:56 +0700 Subject: [PATCH 1/3] fix/mistral-nemo-chat-template --- engine/config/chat_template_renderer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engine/config/chat_template_renderer.h b/engine/config/chat_template_renderer.h index f40894f7b..63a47ecf3 100644 --- a/engine/config/chat_template_renderer.h +++ b/engine/config/chat_template_renderer.h @@ -123,7 +123,7 @@ static int32_t llama_chat_apply_template_internal( ss << content << "\n"; } } else if (role == "user") { - ss << content << " [/INST]"; + ss << "[INST] " << content << " [/INST]"; } else { ss << (space_around_response ? " " : "") << content << (space_around_response ? " " : "") << ""; From fe2acab258a2589bc28c55624a4c908535689fe4 Mon Sep 17 00:00:00 2001 From: nguyenhoangthuan99 Date: Mon, 30 Sep 2024 16:24:22 +0700 Subject: [PATCH 2/3] Fix: change log when re download model --- engine/commands/model_pull_cmd.cc | 2 +- engine/services/download_service.cc | 2 ++ engine/services/model_service.cc | 2 -- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/engine/commands/model_pull_cmd.cc b/engine/commands/model_pull_cmd.cc index 88a474e86..784d6e0eb 100644 --- a/engine/commands/model_pull_cmd.cc +++ b/engine/commands/model_pull_cmd.cc @@ -7,7 +7,7 @@ void ModelPullCmd::Exec(const std::string& input) { if (result.has_error()) { CLI_LOG(result.error()); } else { - CLI_LOG("Model downloaded successfully!"); + CLI_LOG("Model download process completed successfully!"); } } }; // namespace commands diff --git a/engine/services/download_service.cc b/engine/services/download_service.cc index d985636f2..5ae5974a9 100644 --- a/engine/services/download_service.cc +++ b/engine/services/download_service.cc @@ -183,6 +183,7 @@ cpp::result DownloadService::Download( CLI_LOG("Resuming download.."); } else { CLI_LOG("Start over.."); + return {}; } } else { CLI_LOG(download_item.localPath.filename().string() @@ -231,6 +232,7 @@ cpp::result DownloadService::Download( fclose(file); curl_easy_cleanup(curl); + CLI_LOG("Model " << download_id << " downloaded successfully!") return {}; } diff --git a/engine/services/model_service.cc b/engine/services/model_service.cc index 0e25e71ab..344c9506a 100644 --- a/engine/services/model_service.cc +++ b/engine/services/model_service.cc @@ -223,7 +223,6 @@ cpp::result ModelService::HandleUrl( }}}}; auto on_finished = [&](const DownloadTask& finishedTask) { - CLI_LOG("Model " << finishedTask.id << " downloaded successfully!") auto gguf_download_item = finishedTask.items[0]; ParseGguf(gguf_download_item, author); }; @@ -295,7 +294,6 @@ cpp::result ModelService::DownloadModelFromCortexso( return cpp::fail(result.error()); } - CLI_LOG("Model " << model_id << " downloaded successfully!") return model_id; } From 0b21aee7e78bb6a5755ce3104595e79b8ab57ed1 Mon Sep 17 00:00:00 2001 From: nguyenhoangthuan99 Date: Mon, 30 Sep 2024 17:07:49 +0700 Subject: [PATCH 3/3] fix: remove unnecessary logs --- engine/commands/model_pull_cmd.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/engine/commands/model_pull_cmd.cc b/engine/commands/model_pull_cmd.cc index 784d6e0eb..b275f8beb 100644 --- a/engine/commands/model_pull_cmd.cc +++ b/engine/commands/model_pull_cmd.cc @@ -6,8 +6,6 @@ void ModelPullCmd::Exec(const std::string& input) { auto result = model_service_.DownloadModel(input); if (result.has_error()) { CLI_LOG(result.error()); - } else { - CLI_LOG("Model download process completed successfully!"); - } + } } }; // namespace commands