This repository was archived by the owner on Jul 4, 2025. It is now read-only.
Model update command/api #1309
Merged
Model update command/api #1309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhoangthuan99
requested review from
dan-menlo,
namchuai and
vansangpfiev
and removed request for
namchuai and
vansangpfiev
Signed-off-by: James <[email protected]>
fix: resume download failed
Contributor
|
@nguyenhoangthuan99 Can I check the main purpose of the
|
dan-menlo
approved these changes
Sep 24, 2024
* fix: require sudo for cortex update * fix: comment
…nto feat/model-update-cmd
namchuai
reviewed
Sep 24, 2024
namchuai
reviewed
Sep 24, 2024
namchuai
reviewed
Sep 24, 2024
|
|
||
| void ModelUpdCmd::UpdateConfig(const std::string& key, | ||
| const std::string& value) { | ||
| static const std::unordered_map< |
Contributor
There was a problem hiding this comment.
Hmm, I think there's a better way. We can define a function: UpdateModelConfig(const std::string& attr, std::variant<std::string, explicit_int, explicit_bool>) and handle the update logic there.
However if this works for you then I'm fine with it.
Contributor
There was a problem hiding this comment.
I think should keep it this way. We don't know which format user will input, so need to handle it for specific cases
namchuai
approved these changes
Sep 24, 2024
vansangpfiev
approved these changes
Sep 24, 2024
nguyenhoangthuan99
added a commit
that referenced
this pull request
Sep 24, 2024
* feat: pulling interact with new model.list * feat: return model id when download model success * feat: model delete for new model.list (#1317) * feat: models delete for new models data folder structure * feat: delete model * feat: cortex chat/run/models start with new model data structure (#1301) * feat: cortex chat/run/models start with new model data structure * temp * fix: use model_id from model service and std::get_line * f:m * Model update command/api (#1309) * Model update command/api * fix: resume download failed Signed-off-by: James <[email protected]> * fix: align github syntax for cuda (#1316) * fix: require sudo for cortex update (#1318) * fix: require sudo for cortex update * fix: comment * refactor code * Format code * Add clean up when finish test * remove model.list after finish test * Fix windows CI build --------- Signed-off-by: James <[email protected]> Co-authored-by: James <[email protected]> Co-authored-by: vansangpfiev <[email protected]> * Add more fields to handle when update --------- Signed-off-by: James <[email protected]> Co-authored-by: James <[email protected]> Co-authored-by: vansangpfiev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1154
command option:
Now cortex.cpp can update model parameters by passing it to this command, only passed argument will be updated
If successfully Update, it will output which parameters of model ID is updated