Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Commit 7ae8a15

Browse files
committed
fix: remove deprecated parameters and adjust ignored list
Removed deprecated parameters such as "dynatemp_exponent" and "ctx_len" handling logic, which were no longer needed. Added "flash_attn" back to the ignored parameters list. Cleaned up the parameter conversion logic by removing conditional blocks for specific model optimizations that are no longer required.
1 parent 8725f38 commit 7ae8a15

File tree

1 file changed

+1
-20
lines changed

1 file changed

+1
-20
lines changed

engine/extensions/local-engine/local_engine.cc

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ const std::unordered_set<std::string> kIgnoredParams = {
2323
"user_prompt", "min_keep", "mirostat", "mirostat_eta",
2424
"mirostat_tau", "text_model", "version", "n_probs",
2525
"object", "penalize_nl", "precision", "size",
26-
"flash_attn",
27-
"stop", "tfs_z", "typ_p", "caching_enabled"};
26+
"flash_attn", "stop", "tfs_z", "typ_p", "caching_enabled"};
2827

2928
const std::unordered_map<std::string, std::string> kParamsMap = {
3029
{"cpu_threads", "--threads"},
@@ -35,7 +34,6 @@ const std::unordered_map<std::string, std::string> kParamsMap = {
3534
{"top_k", "--top-k"},
3635
{"top_p", "--top-p"},
3736
{"min_p", "--min-p"},
38-
{"dynatemp_exponent", "--dynatemp-exp"},
3937
{"ctx_len", "--ctx-size"},
4038
{"ngl", "-ngl"},
4139
};
@@ -64,16 +62,6 @@ std::vector<std::string> ConvertJsonToParamsVector(const Json::Value& root) {
6462
std::transform(lowered.begin(), lowered.end(), lowered.begin(), [](unsigned char c) {
6563
return std::tolower(c);
6664
});
67-
if ((lowered.find("jan") != std::string::npos && lowered.find("nano") != std::string::npos) || lowered.find("qwen") != std::string::npos) {
68-
res.push_back("--temp");
69-
res.push_back("0.7");
70-
res.push_back("--top-p");
71-
res.push_back("0.8");
72-
res.push_back("--top-k");
73-
res.push_back("20");
74-
res.push_back("--min-p");
75-
res.push_back("0");
76-
}
7765
}
7866
continue;
7967
} else if (kIgnoredParams.find(member) != kIgnoredParams.end()) {
@@ -105,14 +93,7 @@ std::vector<std::string> ConvertJsonToParamsVector(const Json::Value& root) {
10593
res.push_back("--ignore_eos");
10694
}
10795
continue;
108-
} else if (member == "ctx_len") {
109-
if (!root[member].isNull()) {
110-
res.push_back("--ctx-size");
111-
res.push_back(root[member].asString());
112-
}
113-
continue;
11496
}
115-
11697
// Generic handling for other members
11798
res.push_back("--" + member);
11899
if (root[member].isString()) {

0 commit comments

Comments
 (0)