Merge pull request #1372 from ionic-team/listen

fix(serve): start listening when watch is ready

Author: imhoffd

src/dev-server/http-server.ts

@@ -28,9 +28,6 @@ export function createHttpServer(config: ServeConfig): express.Application {
 
   const app = express();
   app.set('serveConfig', config);
-  app.listen(config.httpPort, config.host, function() {
-    Logger.debug(`listening on ${config.httpPort}`);
-  });
 
   app.get('/', serveIndex);
   app.use('/', express.static(config.wwwDir));

src/serve.ts

@@ -1,3 +1,4 @@
+import * as express from 'express';
 import { BuildContext } from './util/interfaces';
 import { getConfigValue, hasConfigValue } from './util/config';
 import { BuildError } from './util/errors';
@@ -20,11 +21,24 @@ export function serve(context: BuildContext) {
   setContext(context);
 
   let config: ServeConfig;
+  let httpServer: express.Application;
   const host = getHttpServerHost(context);
   const notificationPort = getNotificationPort(context);
   const liveReloadServerPort = getLiveReloadServerPort(context);
   const hostPort = getHttpServerPort(context);
 
+  function finish() {
+    if (config) {
+      if (httpServer) {
+        httpServer.listen(config.httpPort, config.host, function() {
+          Logger.debug(`listening on ${config.httpPort}`);
+        });
+      }
+
+      onReady(config, context);
+    }
+  }
+
   return findClosestOpenPorts(host, [notificationPort, liveReloadServerPort, hostPort])
     .then(([notificationPortFound, liveReloadServerPortFound, hostPortFound]) => {
       const hostLocation = (host === '0.0.0.0') ? 'localhost' : host;
@@ -51,12 +65,12 @@ export function serve(context: BuildContext) {
 
       createNotificationServer(config);
       createLiveReloadServer(config);
-      createHttpServer(config);
+      httpServer = createHttpServer(config);
 
       return watch(context);
     })
     .then(() => {
-      onReady(config, context);
+      finish();
       return config;
     }, (err: BuildError) => {
       throw err;
@@ -65,10 +79,7 @@ export function serve(context: BuildContext) {
       if (err && err.isFatal) {
         throw err;
       } else {
-        if (config) {
-          onReady(config, context);
-        }
-
+        finish();
         return config;
       }
     });