From c76badfb0852619e5997f7d8c46006edfffce92c Mon Sep 17 00:00:00 2001 From: devops117 <55235206+devops117@users.noreply.github.com> Date: Wed, 23 Nov 2022 10:40:27 +0530 Subject: [PATCH 1/2] make the docstring more readable and improve the list_models logic Signed-off-by: devops117 <55235206+devops117@users.noreply.github.com> --- ldm/invoke/model_cache.py | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/ldm/invoke/model_cache.py b/ldm/invoke/model_cache.py index 645a6fd4da1..3bb1b7e928a 100644 --- a/ldm/invoke/model_cache.py +++ b/ldm/invoke/model_cache.py @@ -125,15 +125,18 @@ def set_default_model(self,model_name:str) -> None: def list_models(self) -> dict: ''' Return a dict of models in the format: - { model_name1: {'status': ('active'|'cached'|'not loaded'), - 'description': description, - }, - model_name2: { etc } + { + model_name1: { + 'status': ('active'|'cached'|'not loaded'), + 'description': description, + }, + model_name2: { etc }, + } ''' - result = dict() - for name in self.config: + models = {} + for name, config in self.config.items(): try: - description = self.config[name].description + description = config.description except ConfigAttributeError: description = '' @@ -144,11 +147,13 @@ def list_models(self) -> dict: else: status = 'not loaded' - result[name]={ - 'status' : status, - 'description' : description - } - return result + models = models.update( + name = { + 'status': status, + 'description': description, + }) + + return models def print_models(self) -> None: ''' From 7c658c6d76a1d8d7c334293280b4d6143c1fa3b9 Mon Sep 17 00:00:00 2001 From: devops117 <55235206+devops117@users.noreply.github.com> Date: Mon, 28 Nov 2022 19:20:38 +0530 Subject: [PATCH 2/2] model_cache.py: fix list_models Signed-off-by: devops117 <55235206+devops117@users.noreply.github.com> --- ldm/invoke/model_cache.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ldm/invoke/model_cache.py b/ldm/invoke/model_cache.py index 48c504c394f..58cf91eae30 100644 --- a/ldm/invoke/model_cache.py +++ b/ldm/invoke/model_cache.py @@ -147,7 +147,7 @@ def list_models(self) -> dict: else: status = 'not loaded' - models = models.update( + models.update( name = { 'status': status, 'description': description,