From f8befc13a5eea748fa9465563ead855d6cf1f48e Mon Sep 17 00:00:00 2001 From: isc-tleavitt <73311181+isc-tleavitt@users.noreply.github.com> Date: Mon, 24 Jun 2024 10:24:25 -0400 Subject: [PATCH] fix: menu item names in VSCode/SMP Fixes #372 --- CHANGELOG.md | 2 ++ cls/SourceControl/Git/Extension.cls | 7 ++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dc070595..80323236 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Added a new "Branch" parameter to `##class(SourceControl.Git.PullEventHandler)` (#351) - Command-line utility to do a baseline export of items in a namespace +### Fixed +- Menu items names are properly translated from internal name in VSCode, Management Portal (#372) ## [2.3.1] - 2024-04-30 diff --git a/cls/SourceControl/Git/Extension.cls b/cls/SourceControl/Git/Extension.cls index 9ef4a125..697385f4 100644 --- a/cls/SourceControl/Git/Extension.cls +++ b/cls/SourceControl/Git/Extension.cls @@ -106,7 +106,6 @@ Method LocalizeName(name As %String) As %String Method OnSourceMenuItem(name As %String, ByRef Enabled As %String, ByRef DisplayName As %String, InternalName As %String) As %Status { - if name = "Settings" { set Enabled = 1 quit $$$OK @@ -159,6 +158,9 @@ Method OnSourceMenuItem(name As %String, ByRef Enabled As %String, ByRef Display } else { set Enabled = -1 } + if (name '= "") { + set DisplayName = ..LocalizeName(name) + } quit $$$OK } @@ -187,6 +189,9 @@ Method OnSourceMenuContextItem(itemName As %String, menuItemName As %String, ByR } else { set Enabled = $case(menuItemName, "AddToSC":1,:-1) } + if (menuItemName '= "") { + set DisplayName = ..LocalizeName(menuItemName) + } quit $$$OK }