From 564181aef615e31bb1be703c745b1a5ce93a814a Mon Sep 17 00:00:00 2001 From: Ben Donnelly Date: Thu, 22 Jun 2023 10:19:39 +0100 Subject: [PATCH 1/2] chore(build): run actions on PR --- .github/workflows/on_push.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/on_push.yaml b/.github/workflows/on_push.yaml index 945cad1..cce14e0 100644 --- a/.github/workflows/on_push.yaml +++ b/.github/workflows/on_push.yaml @@ -1,6 +1,8 @@ name: Tests on: + pull_request: + branches: [ "master" ] push: branches: - master From fb255d1f60cbd0821afa924157fa31e426659f43 Mon Sep 17 00:00:00 2001 From: Ben Donnelly Date: Thu, 22 Jun 2023 10:23:19 +0100 Subject: [PATCH 2/2] fix(config): correct test for config from env --- test/test_deep/config/test_config_service.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_deep/config/test_config_service.py b/test/test_deep/config/test_config_service.py index a36f284..3d7ba48 100644 --- a/test/test_deep/config/test_config_service.py +++ b/test/test_deep/config/test_config_service.py @@ -25,6 +25,6 @@ def test_custom_attr_callable(self): self.assertEqual(service.SOME_VALUE, 'thing') def test_env_attr(self): - items_ = os.environ.get('PATH') + items_ = os.environ.setdefault("DEEP_PATH", "a thing") service = ConfigService({}) self.assertEqual(service.PATH, items_)