This repository was archived by the owner on Aug 5, 2022. It is now read-only.
[uart] Protect ring buffer access in ISRs w/ irq_lock not mutex #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not safe to be locking / unlocking mutexes from an ISR but we were doing that because zjs_signal_callback is intended to be called by ISRs. This was causing a hang in UART module after more careful locking was added recently. Fixes intel#1541 Signed-off-by: Geoff Gustafson <[email protected]>
Signed-off-by: Geoff Gustafson <[email protected]>
Contributor
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not safe to be locking / unlocking mutexes from an ISR but we
were doing that because zjs_signal_callback is intended to be called
by ISRs. This was causing a hang in UART module after more careful
locking was added recently.
Fixes #1541
Signed-off-by: Geoff Gustafson [email protected]