Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Commit a85729e

Browse files
committed
Formatting skeleton-subsystem code with clang-format
Signed-off-by: Thomas Cahuzac <[email protected]>
1 parent 861a700 commit a85729e

File tree

7 files changed

+40
-52
lines changed

7 files changed

+40
-52
lines changed

skeleton-subsystem/SkeletonMappingKeys.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@
3030
#pragma once
3131

3232
// Mapping item types
33-
enum SkeletonItemType {
33+
enum SkeletonItemType
34+
{
3435
ESkeletonOwner,
3536
EAmend1,
3637
EAmend2,

skeleton-subsystem/SkeletonSubsystem.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
#define base CSubsystem
3636

3737
// Implementation
38-
CSkeletonSubsystem::CSkeletonSubsystem(const std::string& strName, core::log::Logger& logger)
38+
CSkeletonSubsystem::CSkeletonSubsystem(const std::string &strName, core::log::Logger &logger)
3939
: base(strName, logger)
4040
{
4141
// Provide mapping keys to upper layer
@@ -44,5 +44,6 @@ CSkeletonSubsystem::CSkeletonSubsystem(const std::string& strName, core::log::Lo
4444
addContextMappingKey("Amend2");
4545

4646
// Provide creators to upper layer
47-
addSubsystemObjectFactory(new TSubsystemObjectFactory<CSkeletonSubsystemObject>("Message", 1 << ESkeletonOwner));
47+
addSubsystemObjectFactory(
48+
new TSubsystemObjectFactory<CSkeletonSubsystemObject>("Message", 1 << ESkeletonOwner));
4849
}

skeleton-subsystem/SkeletonSubsystem.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,5 @@
3434
class CSkeletonSubsystem : public CSubsystem
3535
{
3636
public:
37-
CSkeletonSubsystem(const std::string& strName, core::log::Logger& logger);
38-
37+
CSkeletonSubsystem(const std::string &strName, core::log::Logger &logger);
3938
};
40-

skeleton-subsystem/SkeletonSubsystemBuilder.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,9 @@
3131
#include "LoggingElementBuilderTemplate.h"
3232
#include "SkeletonSubsystem.h"
3333

34-
35-
void PARAMETER_FRAMEWORK_PLUGIN_ENTRYPOINT_V1(CSubsystemLibrary* pSubsystemLibrary, core::log::Logger& logger)
34+
void PARAMETER_FRAMEWORK_PLUGIN_ENTRYPOINT_V1(CSubsystemLibrary *pSubsystemLibrary,
35+
core::log::Logger &logger)
3636
{
3737
pSubsystemLibrary->addElementBuilder(
38-
"Skeleton",
39-
new TLoggingElementBuilderTemplate<CSkeletonSubsystem>(logger));
38+
"Skeleton", new TLoggingElementBuilderTemplate<CSkeletonSubsystem>(logger));
4039
}

skeleton-subsystem/SkeletonSubsystemObject.cpp

Lines changed: 21 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -46,43 +46,36 @@
4646
using std::string;
4747

4848
CSkeletonSubsystemObject::CSkeletonSubsystemObject(
49-
const string& strMappingValue,
50-
CInstanceConfigurableElement* pInstanceConfigurableElement,
51-
const CMappingContext& context,
52-
core::log::Logger& logger
53-
) :
54-
base(pInstanceConfigurableElement,
55-
logger,
56-
strMappingValue,
57-
EAmend1,
58-
EAmendEnd - EAmend1 + 1,
59-
context),
60-
_bWrongElementTypeError(false)
49+
const string &strMappingValue, CInstanceConfigurableElement *pInstanceConfigurableElement,
50+
const CMappingContext &context, core::log::Logger &logger)
51+
: base(pInstanceConfigurableElement, logger, strMappingValue, EAmend1, EAmendEnd - EAmend1 + 1,
52+
context),
53+
_bWrongElementTypeError(false)
6154
{
6255
// Get actual element type
63-
const CParameterType* pParameterType = static_cast<const CParameterType*>(pInstanceConfigurableElement->getTypeElement());
56+
const CParameterType *pParameterType =
57+
static_cast<const CParameterType *>(pInstanceConfigurableElement->getTypeElement());
6458

6559
// Retrieve sizes
6660
_scalarSize = pParameterType->getSize();
6761
_arraySize = pInstanceConfigurableElement->getFootPrint() / _scalarSize;
6862

6963
// Construct message
70-
_strMessage = context.getItem(ESkeletonOwner) + ":" + strMappingValue ;
64+
_strMessage = context.getItem(ESkeletonOwner) + ":" + strMappingValue;
7165

7266
// Handle types
7367
// Check we are able to handle elements (no exception support, defer the error)
74-
switch(pInstanceConfigurableElement->getType()) {
68+
switch (pInstanceConfigurableElement->getType()) {
7569

76-
case CInstanceConfigurableElement::EParameter:
77-
break;
78-
default:
79-
_bWrongElementTypeError = true;
80-
break;
70+
case CInstanceConfigurableElement::EParameter:
71+
break;
72+
default:
73+
_bWrongElementTypeError = true;
74+
break;
8175
}
82-
8376
}
8477
// Sync to/from HW
85-
bool CSkeletonSubsystemObject::accessHW(bool bReceive, string& strError)
78+
bool CSkeletonSubsystemObject::accessHW(bool bReceive, string &strError)
8679
{
8780
// Check parameter type is ok (deferred error, no exceptions available :-()
8881
if (_bWrongElementTypeError) {
@@ -95,11 +88,11 @@ bool CSkeletonSubsystemObject::accessHW(bool bReceive, string& strError)
9588
return base::accessHW(bReceive, strError);
9689
}
9790

98-
bool CSkeletonSubsystemObject::sendToHW(string& /*strError*/)
91+
bool CSkeletonSubsystemObject::sendToHW(string & /*strError*/)
9992
{
100-
void* pvValue = alloca(_scalarSize);
93+
void *pvValue = alloca(_scalarSize);
10194

102-
for (size_t index = 0 ; index < _arraySize ; index++) {
95+
for (size_t index = 0; index < _arraySize; index++) {
10396

10497
// Read Value in BlackBoard
10598
blackboardRead(pvValue, _scalarSize);
@@ -111,11 +104,11 @@ bool CSkeletonSubsystemObject::sendToHW(string& /*strError*/)
111104
return true;
112105
}
113106

114-
bool CSkeletonSubsystemObject::receiveFromHW(string& /*strError*/)
107+
bool CSkeletonSubsystemObject::receiveFromHW(string & /*strError*/)
115108
{
116-
void* pvValue = alloca(_scalarSize);
109+
void *pvValue = alloca(_scalarSize);
117110

118-
for (size_t index = 0 ; index < _arraySize ; index++) {
111+
for (size_t index = 0; index < _arraySize; index++) {
119112

120113
// Retreive here the value
121114
std::cout << "Retreive from HW: " << _strMessage << std::endl;

skeleton-subsystem/SkeletonSubsystemObject.h

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,20 +36,19 @@ class CMappingContext;
3636
class CSkeletonSubsystemObject : public CFormattedSubsystemObject
3737
{
3838
public:
39-
CSkeletonSubsystemObject(const std::string& strMappingValue,
40-
CInstanceConfigurableElement* pInstanceConfigurableElement,
41-
const CMappingContext& context,
42-
core::log::Logger& logger);
39+
CSkeletonSubsystemObject(const std::string &strMappingValue,
40+
CInstanceConfigurableElement *pInstanceConfigurableElement,
41+
const CMappingContext &context, core::log::Logger &logger);
4342

4443
protected:
4544
// from CSubsystemObject
4645
// Sync to/from HW
47-
virtual bool sendToHW(std::string& strError);
48-
virtual bool receiveFromHW(std::string& strError);
46+
virtual bool sendToHW(std::string &strError);
47+
virtual bool receiveFromHW(std::string &strError);
4948

5049
private:
5150
// Sync to/from HW
52-
virtual bool accessHW(bool bReceive, std::string& strError);
51+
virtual bool accessHW(bool bReceive, std::string &strError);
5352

5453
protected:
5554
// Scalar parameter size for elementary access

skeleton-subsystem/test/main.cpp

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,13 @@
3434
class MyLogger final : public CParameterMgrFullConnector::ILogger
3535
{
3636
public:
37-
void info(const std::string& log) override {
38-
std::cout << "Info: " << log << std::endl;
39-
}
37+
void info(const std::string &log) override { std::cout << "Info: " << log << std::endl; }
4038

41-
void warning(const std::string& log) override {
42-
std::cerr << "Warning: " << log << std::endl;
43-
}
39+
void warning(const std::string &log) override { std::cerr << "Warning: " << log << std::endl; }
4440
};
4541

46-
int main(void) {
42+
int main(void)
43+
{
4744
MyLogger logger;
4845
CParameterMgrFullConnector instance("toplevel.xml");
4946
instance.setLogger(&logger);

0 commit comments

Comments
 (0)