XmlElement::getAttribute: throw on illegal user value

Signed-off-by: David Wagner <[email protected]>

Author: dawagner

xmlserializer/XmlElement.cpp

@@ -31,6 +31,7 @@
 #include <libxml/tree.h>
 #include "convert.hpp"
 #include <stdlib.h>
+#include <stdexcept>
 
 using std::string;
 
@@ -79,10 +80,6 @@ bool CXmlElement::hasAttribute(const string &strAttributeName) const
 template <>
 bool CXmlElement::getAttribute<std::string>(const string &name, string &value) const
 {
-    if (!hasAttribute(name)) {
-        return false;
-    }
-
     string backup = value;
     xmlChar *pucXmlValue = xmlGetProp((xmlNode *)_pXmlElement, (const xmlChar *)name.c_str());
     if (pucXmlValue == nullptr) {
@@ -108,7 +105,7 @@ bool CXmlElement::getAttribute(const std::string &name, T &value) const
     T backup = value;
     if (!convertTo<T>(rawValue, value)) {
         value = backup;
-        return false;
+        throw std::domain_error("\'" + rawValue + "\' could not be parsed as the requested type.");
     }
 
     return true;