[mlir] Relax ASM parser requirements about operands Type presence

Author: Vladislav Vinogradov

mlir/include/mlir/IR/OpImplementation.h

@@ -1449,13 +1449,19 @@ class OpAsmParser : public AsmParser {
                   SmallVectorImpl<Value> &result) {
     size_t operandSize = llvm::range_size(operands);
     size_t typeSize = llvm::range_size(types);
-    if (operandSize != typeSize)
+    if (typeSize != 0 && operandSize != typeSize)
       return emitError(loc)
              << operandSize << " operands present, but expected " << typeSize;
 
-    for (auto [operand, type] : llvm::zip_equal(operands, types))
-      if (resolveOperand(operand, type, result))
-        return failure();
+    if (typeSize == 0) {
+      for (auto it : operands)
+        if (resolveOperand(it, Type(), result))
+          return failure();
+    } else {
+      for (auto [operand, type] : llvm::zip_equal(operands, types))
+        if (resolveOperand(operand, type, result))
+          return failure();
+    }
     return success();
   }
 

mlir/lib/AsmParser/Parser.cpp

@@ -984,17 +984,6 @@ Value OperationParser::resolveSSAUse(UnresolvedOperand useInfo, Type type) {
       return nullptr;
     }
 
-    // Explicit type specification can be omitted, only if the Value was already
-    // defined prior in the same block.
-    if (!type && result.getParentBlock() != opBuilder.getBlock()) {
-      emitError(useInfo.location, "value '")
-          .append(useInfo.name, "' was defined in separate block and requires "
-                                "explicit type definition")
-          .attachNote(getEncodedSourceLocation(entries[useInfo.number].loc))
-          .append("defined here");
-      return nullptr;
-    }
-
     return maybeRecordUse(result);
   }