remove all wd flag to enable warnings when LLVM_ENABLE_WARNINGS is ON

Signed-off-by: Zhu, Shaojie <[email protected]>

Author: ShaojieZhuIntel

llvm/cmake/modules/HandleLLVMOptions.cmake

@@ -684,8 +684,6 @@ if ( LLVM_COMPILER_IS_GCC_COMPATIBLE AND LLVM_ENABLE_MODULES )
   endif()
 endif( LLVM_COMPILER_IS_GCC_COMPATIBLE AND LLVM_ENABLE_MODULES )
 
-option(LLVM_ENABLE_WARNINGS_FOR_PASS_BINSKIM "Enable compiler warnings for pass binskim." OFF)
-
 if (MSVC)
   if (NOT CLANG_CL)
     set(msvc_warning_flags
@@ -748,15 +746,18 @@ if (MSVC)
       )
   endif(NOT CLANG_CL)
 
-  # Remove -wd4146 -wd4244 -wd4267 to pass Binskim
-  if(LLVM_ENABLE_WARNINGS_FOR_PASS_BINSKIM)
-    string(REPLACE "-wd4146" "" msvc_warning_flags "${msvc_warning_flags}")
-    string(REPLACE "-wd4244" "" msvc_warning_flags "${msvc_warning_flags}")
-    string(REPLACE "-wd4267" "" msvc_warning_flags "${msvc_warning_flags}")
-  endif()
-
   # Enable warnings
   if (LLVM_ENABLE_WARNINGS)
+    # Remove all -wd flag to enable warnings
+    if (NOT CLANG_CL)
+      set(msvc_warning_flags
+        # Promoted warnings.
+        -w14062 # Promote 'enumerator in switch of enum is not handled' to level 1 warning.
+
+        # Promoted warnings to errors.
+        -we4238 # Promote 'nonstandard extension used : class rvalue used as lvalue' to error.
+      )
+    endif(NOT CLANG_CL)
     # Put /W4 in front of all the -we flags. cl.exe doesn't care, but for
     # clang-cl having /W4 after the -we flags will re-enable the warnings
     # disabled by -we.