Fixed pruning and distillation bug and remove invalid code #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PenghuiCheng
requested review from
chensuyue,
ftian1,
lvliang-intel and
wenhuach21
Contributor
|
Need to divide into 2 PRs, 1 is new API update which should be merged today, and 1 is new API examples which requires extension test. |
Signed-off-by: Cheng, Penghui <[email protected]>
PenghuiCheng
force-pushed
the
penghuic/pruning_distillation_bug
branch
from
846c45f to
b161319
Compare
Signed-off-by: Cheng, Penghui <[email protected]>
PenghuiCheng
changed the title
ftian1
approved these changes
Dec 9, 2022
PenghuiCheng
changed the title
Signed-off-by: Cheng, Penghui <[email protected]>
Signed-off-by: Cheng, Penghui <[email protected]>
Signed-off-by: Cheng, Penghui <[email protected]>
intel-zhangyi
pushed a commit
that referenced
this pull request
Dec 13, 2022
Signed-off-by: Cheng, Penghui <[email protected]>
zehao-intel
pushed a commit
that referenced
this pull request
Dec 20, 2022
Signed-off-by: Cheng, Penghui <[email protected]> Signed-off-by: zehao-intel <[email protected]>
xin3he
pushed a commit
that referenced
this pull request
Jul 15, 2025
* Added post forward hook to dump measurements according to samples counter * add support in samples counter in config * removed function in RowParllelLinear as it is removed from the vllm upstream code * currently only blocking method is operational, will complete async methods in future commit * fix CR comments * remove unused files * add reslove_input method it can't be defined in vllm due to upstream considerations, so it is copied here * fixed logging acoording to cr * fixed resolve_input and moved the hook function
XuehaoSun
pushed a commit
that referenced
this pull request
Jul 19, 2025
* Added post forward hook to dump measurements according to samples counter * add support in samples counter in config * removed function in RowParllelLinear as it is removed from the vllm upstream code * currently only blocking method is operational, will complete async methods in future commit * fix CR comments * remove unused files * add reslove_input method it can't be defined in vllm due to upstream considerations, so it is copied here * fixed logging acoording to cr * fixed resolve_input and moved the hook function
yiliu30
pushed a commit
that referenced
this pull request
Jul 22, 2025
* Added post forward hook to dump measurements according to samples counter * add support in samples counter in config * removed function in RowParllelLinear as it is removed from the vllm upstream code * currently only blocking method is operational, will complete async methods in future commit * fix CR comments * remove unused files * add reslove_input method it can't be defined in vllm due to upstream considerations, so it is copied here * fixed logging acoording to cr * fixed resolve_input and moved the hook function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cheng, Penghui [email protected]
Type of Change
API changed
Description
Fixed pruning and distillation bug for new API.
Removed neural_compressor.quantization class
Expected Behavior & Potential Risk
Pruning and distillation work with new API.
How has this PR been tested?
Local tested.