Skip to content

Refine Keras Examples for INC New API #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Dec 15, 2022
Merged

Refine Keras Examples for INC New API #219

merged 20 commits into from
Dec 15, 2022

Conversation

@zehao-intel
Copy link
Contributor

@zehao-intel zehao-intel commented Dec 5, 2022

Type of Change

feature or bug fix or documentation or validation or others
API changed or not: No

Description

detail description
JIRA ticket: https://jira.devtools.intel.com/browse/ILITV-2451

Expected Behavior & Potential Risk

the expected behavior that triggered by this PR : refine examples

How has this PR been tested?

how to reproduce the test (including hardware information): extension

Dependency Change?

any library dependency introduced or removed: No

@zehao-intel
Copy link
Contributor Author

zehao-intel commented Dec 5, 2022 •
edited
Loading

Extension: https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/3612/

@zehao-intel
modify config
68ae105 
Signed-off-by: zehao-intel <[email protected]>
@zehao-intel
modify details
9a0004a 
Signed-off-by: zehao-intel <[email protected]>
@zehao-intel
add words to pyspelling white list
d34383d 
Signed-off-by: zehao-intel <[email protected]>
@chensuyue
Copy link
Contributor

chensuyue commented Dec 7, 2022

extension test: https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/3633/artifact/report.html

@zehao-intel
modfiy benchmark
77c1826 
Signed-off-by: zehao-intel <[email protected]>
@zehao-intel
Copy link
Contributor Author

zehao-intel commented Dec 7, 2022 •
edited
Loading

Rebuild extension: https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/3645/

@ftian1
Copy link
Contributor

ftian1 commented Dec 7, 2022

@chensuyue this PR is modifying old examples to use new API. is it recommended way to do that? shall we add totally new examples?

@ftian1 ftian1 self-requested a review December 7, 2022 06:21
@chensuyue
Copy link
Contributor

chensuyue commented Dec 7, 2022

@chensuyue this PR is modifying old examples to use new API. is it recommended way to do that? shall we add totally new examples?

As we synced before all the old examples should be modified into new API or deleted in v2.0.

@zehao-intel
fix latency
61f814a 
Signed-off-by: zehao-intel <[email protected]>
@zehao-intel
fix latency 2
d54d0e9 
Signed-off-by: zehao-intel <[email protected]>
@zehao-intel
Copy link
Contributor Author

zehao-intel commented Dec 7, 2022

Extension: https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/3649/

@chensuyue
Copy link
Contributor

chensuyue commented Dec 7, 2022

please pass extension test before merge.

@ftian1
Copy link
Contributor

ftian1 commented Dec 8, 2022

looks like extenstion tests all fail. pls check why

@ftian1
Copy link
Contributor

ftian1 commented Dec 8, 2022

As we synced before all the old examples should be modified into new API or deleted in v2.0.

@chensuyue who will do this delete action?

@zehao-intel
fix iteration
656e28c 
Signed-off-by: zehao-intel <[email protected]>
@zehao-intel
Copy link
Contributor Author

zehao-intel commented Dec 8, 2022

Extension: https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/3671/

@zehao-intel
Copy link
Contributor Author

zehao-intel commented Dec 8, 2022

Rebuild extension for MobileNetV2: https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/3678/

@chensuyue
Copy link
Contributor

chensuyue commented Dec 11, 2022

extension test
Please check int8/fp32 , new/last(weekly) performance gap.

@zehao-intel
Copy link
Contributor Author

zehao-intel commented Dec 12, 2022

Performance drop is caused by the lack of warmup. I ignored it previously, the old API set it to 5.

Extension test: https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/3712/

@chensuyue
Copy link
Contributor

chensuyue commented Dec 12, 2022

Performance drop is caused by the lack of warmup. I ignored it previously, the old API set it to 5.

Extension test: https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/3712/

please check accuracy issue.

@zehao-intel
fix Model import
ba961c4 
Signed-off-by: zehao-intel <[email protected]>
@zehao-intel
Copy link
Contributor Author

zehao-intel commented Dec 13, 2022

Rebuild extension: https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/3720/

@zehao-intel
modify details
9ad4f76 
Signed-off-by: zehao-intel <[email protected]>
@zehao-intel
Copy link
Contributor Author

zehao-intel commented Dec 14, 2022 •
edited
Loading

Extension: https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/3748/

@zehao-intel
fix shell
8873eae 
Signed-off-by: zehao-intel <[email protected]>
@chensuyue
Copy link
Contributor

chensuyue commented Dec 14, 2022

extension test

@chensuyue chensuyue merged commit 0878bea into master Dec 15, 2022
@chensuyue chensuyue deleted the zehao/newapi_keras branch December 15, 2022 08:52
zehao-intel added a commit that referenced this pull request Dec 20, 2022
@zehao-intel
Refine Keras Examples for INC New API (#219)
7381628 
Signed-off-by: zehao-intel <[email protected]>
VincyZhang pushed a commit that referenced this pull request Feb 12, 2023
@yi1ding
SparseLib benchmark config for CI (#219)
b6b3d2d 
* sync spmm vnni benchmark

* fix append_sum&int8

* new ci

* better benchmark ci

* change summary format

* add readme

* use 8 cores

* fix comments

* update vnni test cases

* fix micro_bs case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lvliang-intel lvliang-intel lvliang-intel left review comments

@ftian1 ftian1 ftian1 approved these changes

@chensuyue chensuyue chensuyue approved these changes

Assignees

No one assigned

Labels

examples extension test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zehao-intel @chensuyue @ftian1 @lvliang-intel