fix bug in TorchSmoothQuant #1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PenghuiCheng
approved these changes
Aug 9, 2023
wenhuach21
approved these changes
Aug 9, 2023
PenghuiCheng
approved these changes
Aug 15, 2023
Signed-off-by: Xin He <[email protected]>
Signed-off-by: Xin He <[email protected]>
Signed-off-by: Xin He <[email protected]>
Signed-off-by: Xin He <[email protected]>
Signed-off-by: Xin He <[email protected]>
XuehaoSun
pushed a commit
that referenced
this pull request
Sep 1, 2023
* [bug fix] when folding=False and QKV is not fully converted to SQLinear. Signed-off-by: Xin He <[email protected]> --------- Signed-off-by: Xin He <[email protected]> Signed-off-by: Sun, Xuehao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
bug fix
Description
when folding=False and QKV is not fully converted to SQLinear.
Expected Behavior & Potential Risk
UT pass
How has this PR been tested?
local test