[Driver][SYCL] Imply -fPIC compilation for wrapped object when using … #3707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-shared Imply -fPIC when generating the wrapped object when using -shared. This reduces confusion if -fPIC is not used when performing the 'link' step using -fsycl as the additional object is created by us, and not by a previous compilation done by the user with -fPIC.
AGindinson
approved these changes
May 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-shared
Imply -fPIC when generating the wrapped object when using -shared. This
reduces confusion if -fPIC is not used when performing the 'link' step
using -fsycl as the additional object is created by us, and not by
a previous compilation done by the user with -fPIC.