[UR][Offload] Add some default returns for device info queries. #19623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typically these are cribbed from the CUDA + Hip adapters, but only when it makes sense as a default for l0 as well (or pertains to something we're already reporting no support for in the case of the device partition stuff).
kbenzie
approved these changes
Jul 30, 2025
callumfare
approved these changes
Jul 31, 2025
RossBrunton
reviewed
Aug 4, 2025
| } | ||
| case UR_DEVICE_INFO_NATIVE_VECTOR_WIDTH_DOUBLE: { | ||
| return ReturnValue(1u); | ||
| } |
Contributor
There was a problem hiding this comment.
If these are just placeholders at the moment, could they be added to #18681 just so we can keep track of them?
Contributor
Author
There was a problem hiding this comment.
added a bit about reporting support for different fp types, which encapsulates these queries
RossBrunton
approved these changes
Aug 4, 2025
Contributor
Author
|
@intel/llvm-gatekeepers please merge, the CI fail is unrelated (no code is touched outside of the offload adapter, which isn't tested by the failing action) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically these are cribbed from the CUDA + Hip adapters, but only when it makes sense as a default for l0 as well (or pertains to something we're already reporting no support for in the case of the device partition stuff).