Skip to content

[CI][UR] Fix UR precommit #18369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[CI][UR] Fix UR precommit #18369

wants to merge 3 commits into from

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented May 8, 2025

Currently has a syntax error preventing it from running:

Invalid workflow file: .github/workflows/ur-precommit.yml#L97
The workflow is not valid. .github/workflows/ur-precommit.yml (Line: 97, Col: 17): Invalid input, platform is not defined in the referenced workflow.

Once it's running, it's failing from what seems to be a formatting issue so I formatted it.

Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex changed the title [CI] Fix UR precommit [CI][UR] Fix UR precommit May 8, 2025
@sarnex
Copy link
Contributor Author

sarnex commented May 8, 2025

The CI is still failing, now with a conformance issue, so that's a bit out of my wheelhouse.

@sarnex sarnex marked this pull request as ready for review May 8, 2025 17:23
@sarnex sarnex requested review from a team as code owners May 8, 2025 17:23
@sarnex
Copy link
Contributor Author

sarnex commented May 8, 2025

Ping @intel/unified-runtime-reviewers, CI is totally broken so hoping to merge this soon, thx!

@kbenzie
Copy link
Contributor

kbenzie commented May 9, 2025

We're investigating the failures.

@RossBrunton
Copy link
Contributor

@sarnex I've had a quick look at this and it looks like a test was marked as expected failure on v1 of level zero but not v2. I've pushed a commit to this MR to disable it on Level Zero v2, hopefully this fixes the issue.

@kbenzie
Copy link
Contributor

kbenzie commented May 9, 2025

Decided to revert the change in #18382 but want to make sure that actually fixes things. Apologies.

@sarnex
Copy link
Contributor Author

sarnex commented May 9, 2025

Thanks for the fix!

@sarnex sarnex closed this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants