[SYCL] Allocate SubmissionInfo completely on stack #18314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move SubmissionInfo to versioned public header and allocate it complitely on stack. Signed-off-by: Alexandr Konovalov <[email protected]>
Alexandr-Konovalov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Alexandr Konovalov <[email protected]>
Alexandr-Konovalov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Alexandr Konovalov <[email protected]>
Signed-off-by: Alexandr Konovalov <[email protected]>
Alexandr-Konovalov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Alexandr-Konovalov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Alexandr-Konovalov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Alexandr Konovalov <[email protected]>
Alexandr-Konovalov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Alexandr-Konovalov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Alexandr-Konovalov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Alexandr Konovalov <[email protected]>
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
changed the title
Signed-off-by: Alexandr Konovalov <[email protected]>
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Alexandr Konovalov <[email protected]>
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Alexandr Konovalov <[email protected]>
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
reviewed
May 8, 2025
sergey-semenov
approved these changes
May 8, 2025
Co-authored-by: Sergey Semenov <[email protected]>
Alexandr-Konovalov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Alexandr Konovalov <[email protected]>
Signed-off-by: Alexandr Konovalov <[email protected]>
Alexandr-Konovalov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Alexandr Konovalov <[email protected]>
Alexandr-Konovalov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
vinser52
approved these changes
May 8, 2025
Alexandr-Konovalov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
approved these changes
May 8, 2025
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
ThreadSanitizer/check_device_global.cpp failure seems unrelated to the PR, see #18349 . |
Contributor
|
@intel/llvm-gatekeepers the PR is ready to merge |
Contributor
aelovikov-intel
left a comment
aelovikov-intel
left a comment
There was a problem hiding this comment.
I also doubt that this approach would work well for non-NFC ABI-breaking changes (e.g. adding new fields or removing old ones). Providing old versions without those new fields could be troublesome, unless all of them are actually optional.
| }; | ||
| #endif | ||
|
|
||
| namespace v1 { |
Contributor
There was a problem hiding this comment.
This way one particular data structure claims entire sycl::detail::vN namespace, so that we can't use the same approach for other APIs (that's the same reason why I think our sycl::_v1 turned out to be rather useless). IMO, it would be better to have detail::submission_info::_v1::SubmissionInfo or something like that. Maybe make submission_info inline itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move SubmissionInfo to versioned public header and allocate it completely on stack.