Skip to content

[SYCL] Coverity scan fixes for #17380 #18133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

[SYCL] Coverity scan fixes for #17380 #18133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sycl/source/detail/device_image_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ class ManagedDeviceGlobalsRegistry {

ManagedDeviceGlobalsRegistry(const ManagedDeviceGlobalsRegistry &) = delete;

ManagedDeviceGlobalsRegistry &
operator=(const ManagedDeviceGlobalsRegistry &) = delete;

~ManagedDeviceGlobalsRegistry() {
try {
unregisterDeviceGlobalsFromContext();
Expand Down Expand Up @@ -128,6 +131,8 @@ class ManagedDeviceBinaries {

ManagedDeviceBinaries(const ManagedDeviceBinaries &) = delete;

ManagedDeviceBinaries &operator=(const ManagedDeviceBinaries &) = delete;

~ManagedDeviceBinaries() {
try {
ProgramManager::getInstance().removeImages(MBinaries);
Expand Down Expand Up @@ -518,7 +523,7 @@ class device_image_impl {
return MProgram;
}

const RTDeviceBinaryImage *const &get_bin_image_ref() const noexcept {
const RTDeviceBinaryImage *const &get_bin_image_ref() const {
return std::get<const RTDeviceBinaryImage *>(MBinImage);
}

Expand Down