-
Notifications
You must be signed in to change notification settings - Fork 794
Update the kernel_queue_specific::max_num_work_group query
#16051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
3597516 to
c559a66
Compare
|
@intel/llvm-reviewers-runtime, could you please review this PR? It's done but I have it marked as draft so that the changes to the UR CMake files don't get merged. I'll revert the change in |
|
@uditagarwal97, thanks for the review. Could you please approve this PR or request any changes you need me to make? We won't be able to merge oneapi-src/unified-runtime#2316 until this PR is approved. |
uditagarwal97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
9059502 to
122f946
Compare
Update calls to `urKernelSuggestMaxCooperativeGroupCountExp` to match the changes in oneapi-src/unified-runtime#2316. This PR also implements the `range<1>` and `range<2>` overloads of the `ext_oneapi_get_info` API from [sycl_ext_oneapi_launch_queries](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_launch_queries.asciidoc). --------- Signed-off-by: Michael Aziz <[email protected]> Co-authored-by: Martin Morrison-Grant <[email protected]>
Update calls to
urKernelSuggestMaxCooperativeGroupCountExpto match the changes in oneapi-src/unified-runtime#2316. This PR also implements therange<1>andrange<2>overloads of theext_oneapi_get_infoAPI from sycl_ext_oneapi_launch_queries.