[SYCL] Prohibit usage of <sycl/sycl.hpp> in E2E tests
#13875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Depends on #13847, only the top commit should be reviewed under this PR. |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sycl/test-e2e/README.md
Outdated
Contributor
There was a problem hiding this comment.
Should we bold "Until then, code outside of this project must keep using <sycl/sycl.hpp> provided by the SYCL2020 specification." ?
It looks important for customers.
uditagarwal97
approved these changes
May 22, 2024
Fine-grained includes should be used instead for the benefits of compile-time. So far, the feature is still internal, customer code should continue using standard header files only. We can consider adding a Nightly workflow running E2E tests with extra compilation flag `-include sycl/sycl.hpp` if people think that would be important to have. I personally think that any potential discrepancies between full `sycl.hpp` and individual includes can be caught in compile-time and it should be enough to have tests in `sycl/test`.
aelovikov-intel
force-pushed
the
no-sycl-hpp
branch
from
4b6d2da to
8827e52
Compare
aelovikov-intel
requested review from
uditagarwal97
and removed request for
a team
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
Resource leak in |
Contributor
|
@aelovikov-intel - sycl/test-e2e/no_sycl_hpp_in_e2e_tests.cpp has been seen failing in both pre-commit (#13888) and post-commit (#13359). |
Contributor
My bad, I removed usage of |
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
May 23, 2024
intel#13875 made sycl/sycl.hpp include in E2E tests prohibited. However, LLVMIntrinsicLowering/sub_byte_bitreverse.cpp snuck in without this check. This commit fixes the includes in that test. Signed-off-by: Larsen, Steffen <[email protected]>
Contributor
steffenlarsen
added a commit
that referenced
this pull request
May 24, 2024
#13875 made sycl/sycl.hpp include in E2E tests prohibited. However, LLVMIntrinsicLowering/sub_byte_bitreverse.cpp snuck in without this check. This commit fixes the includes in that test. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fine-grained includes should be used instead for the benefits of
compile-time. So far, the feature is still internal, customer code
should continue using standard header files only.
We can consider adding a Nightly workflow running E2E tests with extra
compilation flag
-include sycl/sycl.hppif people think that would beimportant to have. I personally think that any potential discrepancies
between full
sycl.hppand individual includes can be caught incompile-time and it should be enough to have tests in
sycl/test.