Apply comments

Signed-off-by: Dmitry Sidorov <[email protected]>

Author: MrSidims

sycl/include/CL/sycl/detail/pi.h

@@ -494,6 +494,12 @@ constexpr pi_mem_flags PI_MEM_FLAGS_HOST_PTR_USE = CL_MEM_USE_HOST_PTR;
 constexpr pi_mem_flags PI_MEM_FLAGS_HOST_PTR_COPY = CL_MEM_COPY_HOST_PTR;
 constexpr pi_mem_flags PI_MEM_FLAGS_HOST_PTR_ALLOC = CL_MEM_ALLOC_HOST_PTR;
 
+// NOTE: this is made 64-bit to match the size of cl_mem_properties_intel to
+// make the translation to OpenCL transparent.
+// TODO: populate
+//
+using pi_mem_properties = pi_bitfield;
+
 // NOTE: queue properties are implemented this way to better support bit
 // manipulations
 using pi_queue_properties = pi_bitfield;
@@ -981,7 +987,7 @@ __SYCL_EXPORT pi_result piextQueueCreateWithNativeHandle(
 //
 __SYCL_EXPORT pi_result piMemBufferCreate(
     pi_context context, pi_mem_flags flags, size_t size, void *host_ptr,
-    pi_mem *ret_mem, const cl_mem_properties_intel *properties = nullptr);
+    pi_mem *ret_mem, const pi_mem_properties *properties = nullptr);
 
 __SYCL_EXPORT pi_result piMemImageCreate(pi_context context, pi_mem_flags flags,
                                          const pi_image_format *image_format,

sycl/plugins/cuda/pi_cuda.cpp

@@ -1628,9 +1628,10 @@ pi_result cuda_piextContextCreateWithNativeHandle(pi_native_handle nativeHandle,
 ///
 pi_result cuda_piMemBufferCreate(pi_context context, pi_mem_flags flags,
                                  size_t size, void *host_ptr, pi_mem *ret_mem,
-                                 const cl_mem_properties_intel *) {
+                                 const pi_mem_properties *properties) {
   // Need input memory object
   assert(ret_mem != nullptr);
+  assert(properties == nullptr && "no mem properties goes to cuda RT yet");
   // Currently, USE_HOST_PTR is not implemented using host register
   // since this triggers a weird segfault after program ends.
   // Setting this constant to true enables testing that behavior.

sycl/plugins/level_zero/pi_level_zero.cpp

@@ -1909,12 +1909,13 @@ pi_result piextQueueCreateWithNativeHandle(pi_native_handle NativeHandle,
 
 pi_result piMemBufferCreate(pi_context Context, pi_mem_flags Flags, size_t Size,
                             void *HostPtr, pi_mem *RetMem,
-                            const cl_mem_properties_intel *) {
+                            const pi_mem_properties *properties) {
 
   // TODO: implement read-only, write-only
   assert((Flags & PI_MEM_FLAGS_ACCESS_RW) != 0);
   assert(Context);
   assert(RetMem);
+  assert(properties == nullptr && "no mem properties goes to l0 RT yet");
 
   void *Ptr;
   ze_device_handle_t ZeDevice = Context->Devices[0]->ZeDevice;

sycl/plugins/opencl/pi_opencl.cpp

@@ -519,7 +519,7 @@ pi_result piextContextCreateWithNativeHandle(pi_native_handle nativeHandle,
 
 pi_result piMemBufferCreate(pi_context context, pi_mem_flags flags, size_t size,
                             void *host_ptr, pi_mem *ret_mem,
-                            const cl_mem_properties_intel *properties) {
+                            const pi_mem_properties *properties) {
   pi_result ret_err = PI_INVALID_OPERATION;
   clCreateBufferWithPropertiesINTEL_fn FuncPtr = nullptr;