Skip to content

Commit 8adbfa5

Browse files
committed
Revert "Use single var to enable both adapters"
This reverts commit 586d0da.
1 parent a733408 commit 8adbfa5

File tree

10 files changed

+16
-18
lines changed

10 files changed

+16
-18
lines changed

devops/scripts/benchmarks/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ To install Unified Runtime in the predefined location, use the `-DCMAKE_INSTALL_
4343

4444
UR build example:
4545
```
46-
$ cmake -DCMAKE_BUILD_TYPE=Release -S~/llvm/unified-runtime -B~/ur_build -DCMAKE_INSTALL_PREFIX=~/ur_install -DUR_BUILD_ADAPTER_L0=ON
46+
$ cmake -DCMAKE_BUILD_TYPE=Release -S~/llvm/unified-runtime -B~/ur_build -DCMAKE_INSTALL_PREFIX=~/ur_install -DUR_BUILD_ADAPTER_L0=ON -DUR_BUILD_ADAPTER_L0_V2=ON
4747
```
4848

4949
### Rebuild

sycl/cmake/modules/FetchUnifiedRuntime.cmake

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ if("level_zero" IN_LIST SYCL_ENABLE_BACKENDS)
4040
set(UR_BUILD_ADAPTER_L0 ON)
4141
endif()
4242
if("level_zero_v2" IN_LIST SYCL_ENABLE_BACKENDS)
43-
set(UR_BUILD_ADAPTER_L0 ON)
43+
set(UR_BUILD_ADAPTER_L0_V2 ON)
4444
endif()
4545
if("cuda" IN_LIST SYCL_ENABLE_BACKENDS)
4646
set(UR_BUILD_ADAPTER_CUDA ON)
@@ -349,6 +349,7 @@ if(CMAKE_SYSTEM_NAME STREQUAL Windows)
349349
-DUR_ENABLE_TRACING:BOOL=${UR_ENABLE_TRACING}
350350
-DUR_ENABLE_COMGR:BOOL=${UR_ENABLE_COMGR}
351351
-DUR_BUILD_ADAPTER_L0:BOOL=${UR_BUILD_ADAPTER_L0}
352+
-DUR_BUILD_ADAPTER_L0_V2:BOOL=${UR_BUILD_ADAPTER_L0_V2}
352353
-DUR_BUILD_ADAPTER_OPENCL:BOOL=${UR_BUILD_ADAPTER_OPENCL}
353354
-DUR_BUILD_ADAPTER_CUDA:BOOL=${UR_BUILD_ADAPTER_CUDA}
354355
-DUR_BUILD_ADAPTER_HIP:BOOL=${UR_BUILD_ADAPTER_HIP}

unified-runtime/CMakeLists.txt

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -271,15 +271,10 @@ if(UR_USE_MSAN)
271271
add_sanitizer_flag(memory)
272272
endif()
273273

274-
if (UR_BUILD_ADAPTER_L0 OR UR_BUILD_ADAPTER_L0_V2)
275-
set(UR_BUILD_ADAPTER_L0_ALL 1)
276-
else()
277-
set(UR_BUILD_ADAPTER_L0_ALL 0)
278-
endif()
279-
280274
if(NOT (UR_BUILD_ADAPTER_CUDA OR UR_BUILD_ADAPTER_HIP
281-
OR UR_BUILD_ADAPTER_L0_ALL OR UR_BUILD_ADAPTER_OPENCL
282-
OR UR_BUILD_ADAPTER_NATIVE_CPU OR UR_BUILD_ADAPTER_ALL))
275+
OR UR_BUILD_ADAPTER_L0 OR UR_BUILD_ADAPTER_OPENCL
276+
OR UR_BUILD_ADAPTER_NATIVE_CPU OR UR_BUILD_ADAPTER_L0_V2
277+
OR UR_BUILD_ADAPTER_ALL))
283278
message(WARNING "No adapters have been enabled; conformance tests will not be ran")
284279
message(STATUS "Consider setting UR_BUILD_ADAPTER_*")
285280
endif()

unified-runtime/source/adapters/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ endfunction()
5757

5858
list(APPEND TEMP_LIST "mock")
5959

60-
if(UR_BUILD_ADAPTER_L0_ALL OR UR_BUILD_ADAPTER_ALL)
60+
if(UR_BUILD_ADAPTER_L0 OR UR_BUILD_ADAPTER_L0_V2 OR UR_BUILD_ADAPTER_ALL)
6161
add_ur_adapter_subdirectory(level_zero)
6262
list(APPEND TEMP_LIST "level_zero")
6363
endif()

unified-runtime/source/adapters/level_zero/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# See LICENSE.TXT
44
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
55

6-
if(UR_BUILD_ADAPTER_L0_ALL)
6+
if(UR_BUILD_ADAPTER_L0)
77
set(ADAPTER_LIB_TYPE SHARED)
88
if(UR_STATIC_ADAPTER_L0)
99
set(ADAPTER_LIB_TYPE STATIC)
@@ -115,7 +115,7 @@ if(UR_BUILD_ADAPTER_L0_ALL)
115115
)
116116
endif()
117117

118-
if(UR_BUILD_ADAPTER_L0_ALL)
118+
if(UR_BUILD_ADAPTER_L0_V2)
119119
add_ur_adapter(ur_adapter_level_zero_v2
120120
SHARED
121121
# sources shared with legacy adapter

unified-runtime/source/common/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# See LICENSE.TXT
44
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
55

6-
if (UR_BUILD_ADAPTER_L0_ALL)
6+
if (UR_BUILD_ADAPTER_L0 OR UR_BUILD_ADAPTER_L0_V2)
77
include(FetchLevelZero)
88
set(UMF_BUILD_LEVEL_ZERO_PROVIDER ON CACHE INTERNAL "Build Level Zero Provider")
99
set(UMF_LEVEL_ZERO_INCLUDE_DIR "${LEVEL_ZERO_INCLUDE_DIR}" CACHE INTERNAL "Level Zero headers")

unified-runtime/test/adapters/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ if(UR_BUILD_ADAPTER_HIP OR UR_BUILD_ADAPTER_ALL)
1313
add_subdirectory(hip)
1414
endif()
1515

16-
if(UR_BUILD_ADAPTER_L0_ALL OR UR_BUILD_ADAPTER_ALL)
16+
if(UR_BUILD_ADAPTER_L0 OR UR_BUILD_ADAPTER_L0_V2 OR UR_BUILD_ADAPTER_ALL)
1717
add_subdirectory(level_zero)
1818
endif()

unified-runtime/test/adapters/level_zero/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,4 +60,6 @@ add_conformance_devices_test(device_select_binary urDeviceSelectBinary.cpp)
6060

6161
add_l0_loader_devices_test(mem_buffer_create_with_native_handle urMemBufferCreateWithNativeHandleShared.cpp)
6262

63-
add_subdirectory(v2)
63+
if(UR_BUILD_ADAPTER_L0_V2)
64+
add_subdirectory(v2)
65+
endif()

unified-runtime/test/conformance/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ if(UR_FOUND_DPCXX)
9292
file(MAKE_DIRECTORY ${UR_CONFORMANCE_DEVICE_BINARIES_DIR})
9393

9494
if("${UR_CONFORMANCE_TARGET_TRIPLES}" STREQUAL "")
95-
if(UR_BUILD_ADAPTER_L0_ALL OR UR_BUILD_ADAPTER_OFFLOAD OR UR_BUILD_ADAPTER_OPENCL OR UR_BUILD_ADAPTER_ALL)
95+
if(UR_BUILD_ADAPTER_L0 OR UR_BUILD_ADAPTER_OFFLOAD OR UR_BUILD_ADAPTER_L0_V2 OR UR_BUILD_ADAPTER_OPENCL OR UR_BUILD_ADAPTER_ALL)
9696
list(APPEND TARGET_TRIPLES "spir64")
9797
endif()
9898
if(UR_BUILD_ADAPTER_CUDA OR UR_BUILD_ADAPTER_OFFLOAD OR UR_BUILD_ADAPTER_ALL)

unified-runtime/test/conformance/exp_command_buffer/native-command/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ if (UR_BUILD_ADAPTER_HIP)
1313
target_link_libraries(exp_command_buffer-test PRIVATE rocmdrv)
1414
endif()
1515

16-
if (UR_BUILD_ADAPTER_L0_ALL)
16+
if (UR_BUILD_ADAPTER_L0 OR UR_BUILD_ADAPTER_L0_v2)
1717
target_sources(exp_command_buffer-test PRIVATE "append_native_L0.cpp")
1818
target_link_libraries(exp_command_buffer-test PRIVATE LevelZeroLoader LevelZeroLoader-Headers)
1919
endif()

0 commit comments

Comments
 (0)