[ESIMD] Deprecate -fsycl-explicit-simd option (#3476)

ESIMD no longer requires -fsycl-explicit-simd flag.

Co-authored-by: Aaron Ballman <[email protected]>

Author: DenisBakhvalov

clang/include/clang/Driver/Options.td

@@ -4377,10 +4377,11 @@ def fsycl : Flag<["-"], "fsycl">, Flags<[NoXarchOption, CoreOption]>, Group<sycl
   HelpText<"Enables SYCL kernels compilation for device">;
 def fno_sycl : Flag<["-"], "fno-sycl">, Flags<[NoXarchOption, CoreOption]>, Group<sycl_Group>,
   HelpText<"Disables SYCL kernels compilation for device">;
-defm sycl_esimd: BoolFOption<"sycl-explicit-simd",
-  LangOpts<"SYCLExplicitSIMD">, DefaultFalse,
-  PosFlag<SetTrue, [CC1Option], "Enable">, NegFlag<SetFalse, [], "Disable">,
-  BothFlags<[NoArgumentUnused, CoreOption], "SYCL explicit SIMD extension.">>;
+// FIXME: -fsycl-explicit-simd is deprecated. remove it when support is dropped.
+def : Flag<["-"], "fsycl-explicit-simd">, Flags<[CoreOption]>, Group<clang_ignored_legacy_options_Group>,
+  HelpText<"Enable SYCL explicit SIMD extension. (deprecated)">;
+def : Flag<["-"], "fno-sycl-explicit-simd">, Flags<[CoreOption]>, Group<clang_ignored_legacy_options_Group>,
+  HelpText<"Disable SYCL explicit SIMD extension. (deprecated)">;
 defm sycl_early_optimizations : OptOutFFlag<"sycl-early-optimizations", "Enable", "Disable", " standard optimization pipeline for SYCL device compiler", [CoreOption]>;
 def fsycl_dead_args_optimization : Flag<["-"], "fsycl-dead-args-optimization">,
   Group<sycl_Group>, Flags<[NoArgumentUnused, CoreOption]>, HelpText<"Enables "

clang/lib/Driver/ToolChains/Clang.cpp

@@ -4354,10 +4354,6 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
     CmdArgs.push_back("-fsycl-is-device");
     CmdArgs.push_back("-fdeclare-spirv-builtins");
 
-    if (Args.hasFlag(options::OPT_fsycl_esimd, options::OPT_fno_sycl_esimd,
-                     false))
-      CmdArgs.push_back("-fsycl-explicit-simd");
-
     // Default value for FPGA is false, for all other targets is true.
     if (!Args.hasFlag(options::OPT_fsycl_early_optimizations,
                       options::OPT_fno_sycl_early_optimizations,
@@ -6663,10 +6659,6 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
       // doing the host pass.
       CmdArgs.push_back("-fsycl-is-host");
 
-      if (Args.hasFlag(options::OPT_fsycl_esimd, options::OPT_fno_sycl_esimd,
-                       false))
-        CmdArgs.push_back("-fsycl-explicit-simd");
-
       if (!D.IsCLMode()) {
         // SYCL library is guaranteed to work correctly only with dynamic
         // MSVC runtime.

clang/test/Driver/sycl-esimd.cpp

@@ -1,10 +1,4 @@
-/// Check that explicit SIMD extension is disabled by default:
-// RUN: %clang -### %s 2>&1 \
-// RUN: | FileCheck -check-prefix=CHECK-DEFAULT %s
-// CHECK-DEFAULT-NOT: "-fsycl-explicit-simd"
-
-/// Check "-fsycl-explicit-simd" is passed when compiling for device and host:
-// RUN: %clang -### -fsycl -fsycl-explicit-simd %s 2>&1 \
-// RUN: | FileCheck -check-prefix=CHECK-SYCL-ESIMD %s
-// CHECK-SYCL-ESIMD: "-cc1"{{.*}} "-fsycl-explicit-simd"{{.*}}
-// CHECK-SYCL-ESIMD: "-cc1"{{.*}} "-fsycl-explicit-simd"{{.*}}
+/// Check that the warning is emmited for using "-fsycl-explicit-simd"
+// RUN: %clang -### -fsycl-explicit-simd %s 2>&1 | FileCheck %s
+// RUN: %clang -### -fno-sycl-explicit-simd %s 2>&1 | FileCheck %s
+// CHECK: the flag '-f{{.*}}sycl-explicit-simd' has been deprecated and will be ignored

clang/test/Driver/sycl-offload.c

@@ -589,7 +589,6 @@
 
 /// Check "-spirv-allow-unknown-intrinsics=llvm.genx." option is emitted for llvm-spirv tool
 // RUN: %clangxx %s -fsycl -### 2>&1 | FileCheck %s --check-prefix=CHK-ALLOW-INTRIN
-// RUN: %clangxx %s -fsycl -fsycl-explicit-simd -### 2>&1 | FileCheck %s --check-prefix=CHK-ALLOW-INTRIN
 // CHK-ALLOW-INTRIN: llvm-spirv{{.*}}-spirv-allow-unknown-intrinsics=llvm.genx.
 
 /// ###########################################################################

clang/test/SemaSYCL/esimd-globals-in-sycl-context.cpp

@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -fsycl-is-device -fsycl-explicit-simd -fsyntax-only -verify %s
+// RUN: %clang_cc1 -fsycl-is-device -fsyntax-only -verify %s
 
 // This test checks usage of an ESIMD global in ESIMD(positive) and SYCL(negative) contexts.
 

sycl/doc/UsersManual.md

@@ -53,6 +53,11 @@ and not recommended to use in production environment.
     Enables/Disables unnamed SYCL lambda kernels support.
     Disabled by default.
 
+**`-f[no-]sycl-explicit-simd`** [DEPRECATED]
+
+    The option was used to enable/disable SYCL explicit SIMD extension.
+    Not used anymore.
+
 ## Optimization options
 
 **`-f[no-]sycl-early-optimizations`**

sycl/test/esimd/block_load_store.cpp

@@ -1,4 +1,4 @@
-// RUN: %clangxx -fsycl -fsycl-explicit-simd -fsycl-device-only -fsyntax-only -Xclang -verify %s
+// RUN: %clangxx -fsycl -fsycl-device-only -fsyntax-only -Xclang -verify %s
 // expected-no-diagnostics
 
 #include <CL/sycl.hpp>

sycl/test/esimd/esimd-util-compiler-eval.cpp

@@ -1,4 +1,4 @@
-// RUN: %clangxx -fsycl -fsycl-explicit-simd -fsycl-device-only -c %s
+// RUN: %clangxx -fsycl -fsycl-device-only -c %s
 // This test checks compile-time evaluation of functions from esimd_util.hpp
 
 #include "CL/sycl.hpp"

sycl/test/esimd/esimd_math.cpp

@@ -1,4 +1,4 @@
-// RUN: %clangxx -fsycl -fsycl-explicit-simd -fsycl-device-only -fsyntax-only -Xclang -verify %s
+// RUN: %clangxx -fsycl -fsycl-device-only -fsyntax-only -Xclang -verify %s
 // expected-no-diagnostics
 
 #include <CL/sycl/INTEL/esimd.hpp>

sycl/test/esimd/flat_atomic.cpp

@@ -1,4 +1,4 @@
-// RUN: %clangxx -fsycl -fsycl-explicit-simd -fsycl-device-only -fsyntax-only -Xclang -verify %s
+// RUN: %clangxx -fsycl -fsycl-device-only -fsyntax-only -Xclang -verify %s
 // expected-no-diagnostics
 
 #include <CL/sycl.hpp>