Address code review comments

Signed-off-by: Sergey Semenov <[email protected]>

Author: sergey-semenov

clang/lib/CodeGen/CodeGenFunction.cpp

@@ -540,8 +540,10 @@ void CodeGenFunction::EmitOpenCLKernelMetadata(const FunctionDecl *FD,
   if (!FD->hasAttr<OpenCLKernelAttr>())
     return;
 
+  // TODO Module identifier is not reliable for this purpose since two modules
+  // can have the same ID, needs improvement
   if (getLangOpts().SYCLIsDevice)
-    Fn->addFnAttr("module-id", Fn->getParent()->getModuleIdentifier());
+    Fn->addFnAttr("sycl-module-id", Fn->getParent()->getModuleIdentifier());
 
   llvm::LLVMContext &Context = getLLVMContext();
 

clang/test/CodeGenSYCL/module-id.cpp

@@ -11,4 +11,4 @@ int main() {
 }
 // CHECK: define spir_kernel void @{{.*}}kernel{{.*}}() #[[KERN_ATTR:[0-9]+]]
 
-// CHECK: #[[KERN_ATTR]] = { {{.*}}"module-id"="{{.*}}module-id.cpp"{{.*}} }
+// CHECK: #[[KERN_ATTR]] = { {{.*}}"sycl-module-id"="{{.*}}module-id.cpp"{{.*}} }