From d0b04dc681963582e5e5c735b5f0ce810b60966e Mon Sep 17 00:00:00 2001 From: Chris Perkins Date: Mon, 23 May 2022 09:15:42 -0700 Subject: [PATCH 1/2] the GroupAlgorithm tests were recently expanded to ensure that all the spir-v 1.3 binary ops were being exercised. Unfortunately, this seems to have introduced a failure on hip/amd. marking these tests as xfail temporarily to unblock other PRs Signed-off-by: Chris Perkins --- SYCL/GroupAlgorithm/SYCL2020/exclusive_scan.cpp | 2 ++ SYCL/GroupAlgorithm/SYCL2020/inclusive_scan.cpp | 2 ++ SYCL/GroupAlgorithm/SYCL2020/reduce.cpp | 2 ++ SYCL/GroupAlgorithm/exclusive_scan.cpp | 2 ++ SYCL/GroupAlgorithm/inclusive_scan.cpp | 2 ++ SYCL/GroupAlgorithm/reduce.cpp | 2 ++ 6 files changed, 12 insertions(+) diff --git a/SYCL/GroupAlgorithm/SYCL2020/exclusive_scan.cpp b/SYCL/GroupAlgorithm/SYCL2020/exclusive_scan.cpp index f68d53bf6d..e64f473a52 100644 --- a/SYCL/GroupAlgorithm/SYCL2020/exclusive_scan.cpp +++ b/SYCL/GroupAlgorithm/SYCL2020/exclusive_scan.cpp @@ -3,6 +3,8 @@ // RUN: %GPU_RUN_PLACEHOLDER %t.out // RUN: %ACC_RUN_PLACEHOLDER %t.out +// XFAIL: hip + #include "support.h" #include #include diff --git a/SYCL/GroupAlgorithm/SYCL2020/inclusive_scan.cpp b/SYCL/GroupAlgorithm/SYCL2020/inclusive_scan.cpp index 86a30d1e4a..30e00df15f 100644 --- a/SYCL/GroupAlgorithm/SYCL2020/inclusive_scan.cpp +++ b/SYCL/GroupAlgorithm/SYCL2020/inclusive_scan.cpp @@ -3,6 +3,8 @@ // RUN: %GPU_RUN_PLACEHOLDER %t.out // RUN: %ACC_RUN_PLACEHOLDER %t.out +// XFAIL: hip + #include "support.h" #include #include diff --git a/SYCL/GroupAlgorithm/SYCL2020/reduce.cpp b/SYCL/GroupAlgorithm/SYCL2020/reduce.cpp index 7a08c16bb5..ed92131e8d 100644 --- a/SYCL/GroupAlgorithm/SYCL2020/reduce.cpp +++ b/SYCL/GroupAlgorithm/SYCL2020/reduce.cpp @@ -3,6 +3,8 @@ // RUN: %GPU_RUN_PLACEHOLDER %t.out // RUN: %ACC_RUN_PLACEHOLDER %t.out +// XFAIL: hip + #include "support.h" #include #include diff --git a/SYCL/GroupAlgorithm/exclusive_scan.cpp b/SYCL/GroupAlgorithm/exclusive_scan.cpp index 1dcf3594ac..2dec1d5292 100644 --- a/SYCL/GroupAlgorithm/exclusive_scan.cpp +++ b/SYCL/GroupAlgorithm/exclusive_scan.cpp @@ -4,6 +4,8 @@ // RUN: %GPU_RUN_PLACEHOLDER %t.out // RUN: %ACC_RUN_PLACEHOLDER %t.out +// XFAIL: hip + #include "support.h" #include #include diff --git a/SYCL/GroupAlgorithm/inclusive_scan.cpp b/SYCL/GroupAlgorithm/inclusive_scan.cpp index ec1f2fb1ce..28cb510812 100644 --- a/SYCL/GroupAlgorithm/inclusive_scan.cpp +++ b/SYCL/GroupAlgorithm/inclusive_scan.cpp @@ -4,6 +4,8 @@ // RUN: %GPU_RUN_PLACEHOLDER %t.out // RUN: %ACC_RUN_PLACEHOLDER %t.out +// XFAIL: hip + #include "support.h" #include #include diff --git a/SYCL/GroupAlgorithm/reduce.cpp b/SYCL/GroupAlgorithm/reduce.cpp index 2969aac210..40b9706dc3 100644 --- a/SYCL/GroupAlgorithm/reduce.cpp +++ b/SYCL/GroupAlgorithm/reduce.cpp @@ -4,6 +4,8 @@ // RUN: %GPU_RUN_PLACEHOLDER %t.out // RUN: %ACC_RUN_PLACEHOLDER %t.out +// XFAIL: hip + #include "support.h" #include #include From 47cf2dccea666bf2f9698dd1048bb98eba5e7bcd Mon Sep 17 00:00:00 2001 From: Chris Perkins Date: Mon, 23 May 2022 12:07:46 -0700 Subject: [PATCH 2/2] comment added / reviewer feedback Signed-off-by: Chris Perkins --- SYCL/GroupAlgorithm/SYCL2020/exclusive_scan.cpp | 2 ++ SYCL/GroupAlgorithm/SYCL2020/inclusive_scan.cpp | 2 ++ SYCL/GroupAlgorithm/SYCL2020/reduce.cpp | 2 ++ SYCL/GroupAlgorithm/exclusive_scan.cpp | 2 ++ SYCL/GroupAlgorithm/inclusive_scan.cpp | 2 ++ 5 files changed, 10 insertions(+) diff --git a/SYCL/GroupAlgorithm/SYCL2020/exclusive_scan.cpp b/SYCL/GroupAlgorithm/SYCL2020/exclusive_scan.cpp index e64f473a52..4023b0e65f 100644 --- a/SYCL/GroupAlgorithm/SYCL2020/exclusive_scan.cpp +++ b/SYCL/GroupAlgorithm/SYCL2020/exclusive_scan.cpp @@ -3,6 +3,8 @@ // RUN: %GPU_RUN_PLACEHOLDER %t.out // RUN: %ACC_RUN_PLACEHOLDER %t.out +// disabling hip because some of the binary_ops tested are not supported +// getting undefined symbols for a handful of __spirv__ * functions. // XFAIL: hip #include "support.h" diff --git a/SYCL/GroupAlgorithm/SYCL2020/inclusive_scan.cpp b/SYCL/GroupAlgorithm/SYCL2020/inclusive_scan.cpp index 30e00df15f..77e7ae39f9 100644 --- a/SYCL/GroupAlgorithm/SYCL2020/inclusive_scan.cpp +++ b/SYCL/GroupAlgorithm/SYCL2020/inclusive_scan.cpp @@ -3,6 +3,8 @@ // RUN: %GPU_RUN_PLACEHOLDER %t.out // RUN: %ACC_RUN_PLACEHOLDER %t.out +// disabling hip because some of the binary_ops tested are not supported +// getting undefined symbols for a handful of __spirv__ * functions. // XFAIL: hip #include "support.h" diff --git a/SYCL/GroupAlgorithm/SYCL2020/reduce.cpp b/SYCL/GroupAlgorithm/SYCL2020/reduce.cpp index ed92131e8d..15ae4084e8 100644 --- a/SYCL/GroupAlgorithm/SYCL2020/reduce.cpp +++ b/SYCL/GroupAlgorithm/SYCL2020/reduce.cpp @@ -3,6 +3,8 @@ // RUN: %GPU_RUN_PLACEHOLDER %t.out // RUN: %ACC_RUN_PLACEHOLDER %t.out +// disabling hip because some of the binary_ops tested are not supported +// getting undefined symbols for a handful of __spirv__ * functions. // XFAIL: hip #include "support.h" diff --git a/SYCL/GroupAlgorithm/exclusive_scan.cpp b/SYCL/GroupAlgorithm/exclusive_scan.cpp index 2dec1d5292..5797d79370 100644 --- a/SYCL/GroupAlgorithm/exclusive_scan.cpp +++ b/SYCL/GroupAlgorithm/exclusive_scan.cpp @@ -4,6 +4,8 @@ // RUN: %GPU_RUN_PLACEHOLDER %t.out // RUN: %ACC_RUN_PLACEHOLDER %t.out +// disabling hip because some of the binary_ops tested are not supported +// getting undefined symbols for a handful of __spirv__ * functions. // XFAIL: hip #include "support.h" diff --git a/SYCL/GroupAlgorithm/inclusive_scan.cpp b/SYCL/GroupAlgorithm/inclusive_scan.cpp index 28cb510812..04e810efe7 100644 --- a/SYCL/GroupAlgorithm/inclusive_scan.cpp +++ b/SYCL/GroupAlgorithm/inclusive_scan.cpp @@ -4,6 +4,8 @@ // RUN: %GPU_RUN_PLACEHOLDER %t.out // RUN: %ACC_RUN_PLACEHOLDER %t.out +// disabling hip because some of the binary_ops tested are not supported +// getting undefined symbols for a handful of __spirv__ * functions. // XFAIL: hip #include "support.h"