Skip to content

Commit 97a2fb1

Browse files
kychendevgfxbot
authored andcommitted
Internal feature
Change-Id: If2ca5df99d45e2c6ca1f2288340adfca0f02ee47
1 parent b64eb84 commit 97a2fb1

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

visa/HWConformity.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3827,12 +3827,11 @@ bool HWConformity::generateAlign1Mad(G4_BB* bb, INST_LIST_ITER iter)
38273827
//swap src0 and src1 as src0 supports imm
38283828
inst->setSrc(src1, 0);
38293829
inst->setSrc(src0, 1);
3830-
} else if (builder.noSrc2Regioning() &&
3831-
src0->isSrcRegRegion() && src1->isSrcRegRegion() &&
3832-
!src0->asSrcRegRegion()->isScalar() &&
3830+
} else if (!isGoodAlign1TernarySrc(inst, 0, true) &&
3831+
src1->isSrcRegRegion() &&
38333832
src1->asSrcRegRegion()->isScalar()) {
3834-
// Swap src0 and src1 if src1 is scalar but src0 is not when src2
3835-
// regioning support is quite limited.
3833+
// Swap src0 and src1 if src1 is scalar but src0 is not a good Align1TernarySrc
3834+
// when src2 regioning support is quite limited.
38363835
inst->setSrc(src1, 0);
38373836
inst->setSrc(src0, 1);
38383837
}

visa/TranslationInterface.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4268,6 +4268,7 @@ int IR_Builder::translateVISADwordAtomicInst(
42684268
startTimer(TIMER_VISA_BUILDER_IR_CONSTRUCTION);
42694269
#endif
42704270

4271+
42714272
surface = lowerSurface255To253(surface, *this);
42724273

42734274
unsigned op = Get_Atomic_Op(atomicOp);
@@ -4529,6 +4530,7 @@ int IR_Builder::translateVISADwordAtomicInst(VISAAtomicOps atomicOp,
45294530
ASSERT_USER(!IsFloatAtomicOps(atomicOp) || hasFloatAtomics(),
45304531
"Float atomic operations are only supported on SKL+ devices!");
45314532

4533+
45324534
surface = lowerSurface255To253(surface, *this);
45334535

45344536
Common_ISA_Exec_Size instExecSize = execSize;
@@ -10396,6 +10398,7 @@ int IR_Builder::translateVISASVMAtomicInst(
1039610398
startTimer(TIMER_VISA_BUILDER_IR_CONSTRUCTION);
1039710399
#endif
1039810400

10401+
1039910402
Common_ISA_Exec_Size instExecSize = execSize;
1040010403
if (execSize == EXEC_SIZE_1 || execSize == EXEC_SIZE_2 || execSize == EXEC_SIZE_4)
1040110404
{

0 commit comments

Comments
 (0)