Fixed incorrect types for rotate inst

As rotate needs to keep its dst/src0 type the same and no widening or
narrowing should be done on those operands, make sure copyProg and defHoist
do not change the type of dst/src0.

Also, make sure to use the larger type of dst/src0 as rotate type to be conservative.
This is to handle the case in which imm src0's type has been changed.

Author: jgu222

visa/G4_IR.cpp

@@ -2368,6 +2368,13 @@ bool G4_INST::canPropagateTo(
         }
     }
 
+    if ((useInst_op == G4_rol || useInst_op == G4_ror) && opndNum == 0 &&
+        (TypeSize(dstType) != TypeSize(srcType) || TypeSize(dstType) != TypeSize(useType)))
+    {
+        // rotation's src0 is sensitive to its type size. No prop if type sizes are different.
+        return false;
+    }
+
     // In general, to check whether that MOV could be propagated:
     //
     //  dst/T1 = src/T0;
@@ -2936,6 +2943,13 @@ bool G4_INST::canHoistTo(const G4_INST *defInst, bool simdBB) const
         }
     }
 
+    if ((defInst->opcode() == G4_rol || defInst->opcode() == G4_ror) &&
+        (TypeSize(defDstType) != TypeSize(srcType) || TypeSize(defDstType) != TypeSize(dstType)))
+    {
+        // rotate's dst is sensitive to its size. Make sure operand's size remains unchanged.
+        return false;
+    }
+
     // Cannot do hoisting if the use inst has src modifier.
     if (getSrc(0)->asSrcRegRegion()->hasModifier())
     {

visa/HWConformity.cpp

@@ -1684,10 +1684,28 @@ bool HWConformity::fixRotate(INST_LIST_ITER i, G4_BB* bb)
 
     if (dst->getTypeSize() != src->getTypeSize())
     {
-        // keep exec type same and change dst to be same type as src
-        replaceDst(i, src->getType());
-        dst = inst->getDst();
-        changed = true;
+        // Expect rotate has the same size for its src0 and its dst.
+        // But visa could change the imm src0 to a different type
+        // Use the larger of src0 and dst as rotation type and keep exec type same.
+        if (dst->getTypeSize() > src->getTypeSize())
+        {
+            // use dst type as rotation type
+            G4_Operand* newSrc = nullptr;
+            if (src->isImm())
+            {
+                newSrc = builder.createImm(newSrc->asImm()->getImm(), dst->getType());
+            }
+            else {
+                newSrc = insertMovBefore(i, 0, dst->getType(), bb);
+            }
+            inst->setSrc(newSrc, 0);
+        }
+        else
+        {
+            // use src type as rotation type.
+            inst->setDest(insertMovAfter(i, dst, src->getType(), bb));
+        }
+        // let it fall-thru
     }
 
     if (dst->getType() == Type_W)