golanci-lint: upgrade to 1.60.3, fix one issue and ignore conversion errors

tkatila · mythi · commit 7e5b280cd109 · 2024-08-27T11:40:35.000+03:00
Signed-off-by: Tuomas Katila &lt;tuomas.katila@intel.com&gt;
diff --git a/.github/workflows/lib-validate.yaml b/.github/workflows/lib-validate.yaml
@@ -42,7 +42,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6
         with:
-          version: v1.57.2
+          version: v1.60.3
           args: -v --timeout 5m
   build:
     name: Build and check device plugins
diff --git a/.golangci.yml b/.golangci.yml
@@ -12,12 +12,12 @@ linters:
     - bodyclose
     - dogsled
     - errcheck
-    - exportloopref
+    - copyloopvar
     - gocognit
     - goconst
     - gocyclo
     - godot
-    - goerr113
+    - err113
     - gofmt
     - goimports
     - gomodguard
@@ -62,6 +62,9 @@ linters-settings:
 
 issues:
   exclude-rules:
+    - linters:
+        - gosec
+      text: "G115"
     - path: _test\.go
       linters:
         - gocognit
diff --git a/Makefile b/Makefile
@@ -10,7 +10,7 @@ EXTRA_BUILD_ARGS ?= ""
 
 CERT_MANAGER_VERSION ?= v1.15.2
 CONTROLLER_GEN_VERSION ?= v0.16.1
-GOLANGCI_LINT_VERSION ?= v1.57.2
+GOLANGCI_LINT_VERSION ?= v1.60.3
 KIND_VERSION ?= v0.23.0
 GOLICENSES_VERSION ?= v1.6.0
 # Default bundle image tag
diff --git a/cmd/internal/labeler/labeler_test.go b/cmd/internal/labeler/labeler_test.go
@@ -638,7 +638,6 @@ func TestLabeling(t *testing.T) {
 			t.Fatalf("can't create temporary subroot directory: %+v", err)
 		}
 
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			err := os.MkdirAll(path.Join(subroot, "0"), 0750)
 			if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -638,7 +638,6 @@ func TestLabeling(t *testing.T) {`
`638`	`638`	`t.Fatalf("can't create temporary subroot directory: %+v", err)`
`639`	`639`	`}`
`640`	`640`
`641`		`- tc := tc`
`642`	`641`	`t.Run(tc.name, func(t *testing.T) {`
`643`	`642`	`err := os.MkdirAll(path.Join(subroot, "0"), 0750)`
`644`	`643`	`if err != nil {`