Skip to content

Commit 0a50e09

Browse files
committed
sgx & gpu crds: mark initImage as depricated and improve comments.
Signed-off-by: Tuomas Katila <[email protected]>
1 parent a074384 commit 0a50e09

File tree

4 files changed

+14
-11
lines changed

4 files changed

+14
-11
lines changed

deployments/operator/crd/bases/deviceplugin.intel.com_gpudeviceplugins.yaml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,15 @@ spec:
5151
properties:
5252
enableMonitoring:
5353
description: EnableMonitoring enables the monitoring resource ('i915_monitoring')
54-
which gives access to all GPU devices on given node.
54+
which gives access to all GPU devices on given node. Typically used
55+
with Intel XPU-Manager.
5556
type: boolean
5657
image:
5758
description: Image is a container image with GPU device plugin executable.
5859
type: string
5960
initImage:
60-
description: InitImage is a container image with tools (e.g., GPU
61-
NFD source hook) installed on each node.
61+
description: 'Depricated: InitImage is a container image with tools
62+
(e.g., GPU NFD source hook) installed on each node.'
6263
type: string
6364
logLevel:
6465
description: LogLevel sets the plugin's log level.
@@ -73,15 +74,16 @@ spec:
7374
preferredAllocationPolicy:
7475
description: PreferredAllocationPolicy sets the mode of allocating
7576
GPU devices on a node. See documentation for detailed description
76-
of the policies. Only valid when SharedDevNum > 1 is set.
77+
of the policies. Only valid when SharedDevNum > 1 is set. Not applicable
78+
with ResourceManager.
7779
enum:
7880
- balanced
7981
- packed
8082
- none
8183
type: string
8284
resourceManager:
8385
description: ResourceManager handles the fractional resource management
84-
for multi-GPU nodes
86+
for multi-GPU nodes. Enable only for clusters with GPU Aware Scheduling.
8587
type: boolean
8688
sharedDevNum:
8789
description: SharedDevNum is a number of containers that can share

deployments/operator/crd/bases/deviceplugin.intel.com_sgxdeviceplugins.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ spec:
5858
description: Image is a container image with SGX device plugin executable.
5959
type: string
6060
initImage:
61-
description: InitImage is a container image with tools (e.g., SGX
62-
NFD source hook) installed on each node.
61+
description: 'Depricated: InitImage is a container image with tools
62+
(e.g., SGX NFD source hook) installed on each node.'
6363
type: string
6464
logLevel:
6565
description: LogLevel sets the plugin's log level.

pkg/apis/deviceplugin/v1/gpudeviceplugin_types.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,12 @@ type GpuDevicePluginSpec struct {
3131
// Image is a container image with GPU device plugin executable.
3232
Image string `json:"image,omitempty"`
3333

34-
// InitImage is a container image with tools (e.g., GPU NFD source hook) installed on each node.
34+
// Depricated: InitImage is a container image with tools (e.g., GPU NFD source hook) installed on each node.
3535
InitImage string `json:"initImage,omitempty"`
3636

3737
// PreferredAllocationPolicy sets the mode of allocating GPU devices on a node.
3838
// See documentation for detailed description of the policies. Only valid when SharedDevNum > 1 is set.
39+
// Not applicable with ResourceManager.
3940
// +kubebuilder:validation:Enum=balanced;packed;none
4041
PreferredAllocationPolicy string `json:"preferredAllocationPolicy,omitempty"`
4142

@@ -47,11 +48,11 @@ type GpuDevicePluginSpec struct {
4748
// +kubebuilder:validation:Minimum=0
4849
LogLevel int `json:"logLevel,omitempty"`
4950

50-
// ResourceManager handles the fractional resource management for multi-GPU nodes
51+
// ResourceManager handles the fractional resource management for multi-GPU nodes. Enable only for clusters with GPU Aware Scheduling.
5152
ResourceManager bool `json:"resourceManager,omitempty"`
5253

5354
// EnableMonitoring enables the monitoring resource ('i915_monitoring')
54-
// which gives access to all GPU devices on given node.
55+
// which gives access to all GPU devices on given node. Typically used with Intel XPU-Manager.
5556
EnableMonitoring bool `json:"enableMonitoring,omitempty"`
5657
}
5758

pkg/apis/deviceplugin/v1/sgxdeviceplugin_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ type SgxDevicePluginSpec struct {
3131
// Image is a container image with SGX device plugin executable.
3232
Image string `json:"image,omitempty"`
3333

34-
// InitImage is a container image with tools (e.g., SGX NFD source hook) installed on each node.
34+
// Depricated: InitImage is a container image with tools (e.g., SGX NFD source hook) installed on each node.
3535
InitImage string `json:"initImage,omitempty"`
3636

3737
// EnclaveLimit is a number of containers that can share the same SGX enclave device.

0 commit comments

Comments
 (0)