-
Notifications
You must be signed in to change notification settings - Fork 891
Added 32-bit Linux builds to Travis script #142
Conversation
raphaelning
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| - sudo dpkg -i nasm_2.13.02-0.1_amd64.deb | ||
| # Cross-compiling to 32-bit Linux | ||
| - mkdir -p ${CHROOT_DIR}/haxm | ||
| - cp -r . ${CHROOT_DIR}/haxm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: If the current directory is our git repo, maybe it would be better to tell wget to use a different location for the downloaded files? E.g. wget -P /tmp/haxm-downloads/ <url> (BTW, -P seems to automatically create the directory). Otherwise this line would copy an extra .deb file, and we would be building from a "dirty" source tree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Fixed as of 2403ad3.
Sure, most of these GCC warnings are good catches of minor issues. The only one I'm not sure about is: which also affects the x86_64 build. Is it because |
Actually, it's because the variable of this type is stored more than once on the stack. There are various limits of frame size depending on the context. |
|
A quick hack is to define once |
|
@krytarowski Thanks! Both solutions sound good to me. |
|
With this change, the |
f0bce43 to
2403ad3
Compare
Signed-off-by: Alexandro Sanchez Bach <[email protected]>
2403ad3 to
385a087
Compare
raphaelning
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Added cross-compilation for 32-bit Linux hosts on the Travis configuration file, based on the scripts provided by @maronz (thank you!) on #133 (comment). As you see, there's some extra warnings triggered when compiling the kernel module for 32-bit Linux hosts, but I'll leave that for future PRs.
Signed-off-by: Alexandro Sanchez Bach [email protected]