Fix DEADCODE Coverity issue

test/acl_context_test.cpp:1116:9:
  Type: Logically dead code (DEADCODE)

test/acl_context_test.cpp:1111:9:
  cond_const: Condition "apitype", taking false branch. Now the value of "apitype" is equal to 0.
test/acl_context_test.cpp:1117:13:
  const: At condition "apitype", the value of "apitype" must be equal to 0.
test/acl_context_test.cpp:1116:9:
  dead_error_condition: The condition "apitype" cannot be true.
test/acl_context_test.cpp:1116:9:
  dead_error_line: Execution cannot reach the expression "clCreateContextFromType(props, 4294967295UL, notify_me, this, &status)" inside this statement: "context = (apitype ? clCrea...".

test/acl_context_test.cpp:1125:11:
  Type: Logically dead code (DEADCODE)

test/acl_context_test.cpp:1103:9:
  assignment: Assigning: "fixed_val" = "0L".
test/acl_context_test.cpp:1124:13:
  const: At condition "fixed_val != 0L", the value of "fixed_val" must be equal to 0.
test/acl_context_test.cpp:1124:9:
  dead_error_condition: The condition "fixed_val != 0L" cannot be true.
test/acl_context_test.cpp:1125:11:
  dead_error_line: Execution cannot reach this statement: "if (!envvals[ienv].valid) {...".

Author: IlanTruanovsky

test/acl_context_test.cpp

@@ -1097,71 +1097,50 @@ MT_TEST(Context, offline_device) {
 
     syncThreads();
 
-    for (int apitype = 0; apitype < 1; apitype++) { // just do test by type.
-      for (int i = 0; i < 2; i++) {                 // without/with platform.
-        int idx = 0;
-        cl_context_properties fixed_val = 0;
-        if (i) {
-          props[idx++] = CL_CONTEXT_PLATFORM;
-          props[idx++] = (cl_context_properties)m_platform;
-          ACL_LOCKED(acl_print_debug_msg(" set platform  %p\n", m_platform));
-        }
-        props[idx++] = 0;
-
-        ACL_LOCKED(acl_print_debug_msg(
-            " create %s with env str '%s' ienv %d \n",
-            (apitype ? "fromType" : "fromList"),
-            (envvals[ienv].str ? envvals[ienv].str : "<nil>"), ienv));
-        cl_int status = CL_INVALID_VALUE;
-        cl_context context =
-            apitype
-                ? clCreateContextFromType(props, CL_DEVICE_TYPE_ALL, notify_me,
-                                          this, &status)
-                : clCreateContext(props, 1, m_device, notify_me, this, &status);
-        ACL_LOCKED(acl_print_debug_msg(" fixed_val %d  valid %d\n",
-                                       (int)fixed_val,
-                                       (int)envvals[ienv].valid));
-        if (fixed_val != 0) {
-          if (!envvals[ienv].valid) {
-            CHECK_EQUAL(CL_INVALID_VALUE, status);
-            continue;
-          }
-          if (envvals[ienv].str != 0) {
-            ACL_LOCKED(acl_print_debug_msg(" %s vs. %s \n", (char *)fixed_val,
-                                           envvals[ienv].str));
-            if (0 != strcmp((char *)fixed_val, envvals[ienv].str)) {
-              CHECK_EQUAL(CL_DEVICE_NOT_AVAILABLE, status);
-              continue;
-            }
-          }
-        }
+    for (int i = 0; i < 2; i++) { // without/with platform.
+      int idx = 0;
+      if (i) {
+        props[idx++] = CL_CONTEXT_PLATFORM;
+        props[idx++] = (cl_context_properties)m_platform;
+        ACL_LOCKED(acl_print_debug_msg(" set platform  %p\n", m_platform));
+      }
+      props[idx++] = 0;
 
-        CHECK_EQUAL(CL_SUCCESS, status);
-        ACL_LOCKED(acl_print_debug_msg(" Got context %p\n", context));
+      ACL_LOCKED(acl_print_debug_msg(
+          " create fromList with env str '%s' ienv %d \n",
+          (envvals[ienv].str ? envvals[ienv].str : "<nil>"), ienv));
 
-        cl_context_properties props_ret[20];
-        size_t size_ret = 0;
-        CHECK_EQUAL(CL_SUCCESS,
-                    clGetContextInfo(context, CL_CONTEXT_PROPERTIES,
-                                     sizeof(props_ret), props_ret, &size_ret));
-        CHECK_EQUAL(sizeof(cl_context_properties) * idx, size_ret);
+      cl_int status = CL_INVALID_VALUE;
 
-        int idx_ret = 0;
-        if (i) {
-          CHECK_EQUAL(CL_CONTEXT_PLATFORM, props_ret[idx_ret++]);
-          CHECK_EQUAL((cl_context_properties)m_platform, props_ret[idx_ret++]);
-        }
+      cl_context context =
+          clCreateContext(props, 1, m_device, notify_me, this, &status);
+      ACL_LOCKED(acl_print_debug_msg("valid %d\n", (int)envvals[ienv].valid));
+
+      CHECK_EQUAL(CL_SUCCESS, status);
+      ACL_LOCKED(acl_print_debug_msg(" Got context %p\n", context));
 
-        CHECK_EQUAL(0, props_ret[idx_ret++]);
-        CHECK_EQUAL(idx, idx_ret);
+      cl_context_properties props_ret[20];
+      size_t size_ret = 0;
+      CHECK_EQUAL(CL_SUCCESS,
+                  clGetContextInfo(context, CL_CONTEXT_PROPERTIES,
+                                   sizeof(props_ret), props_ret, &size_ret));
+      CHECK_EQUAL(sizeof(cl_context_properties) * idx, size_ret);
 
-        syncThreads();
-        ACL_LOCKED(acl_print_debug_msg(" Releaseing context\n"));
-        clReleaseContext(context);
-        syncThreads();
-        CHECK_EQUAL(0, acl_get_num_alloc_cl_context());
-        syncThreads();
+      int idx_ret = 0;
+      if (i) {
+        CHECK_EQUAL(CL_CONTEXT_PLATFORM, props_ret[idx_ret++]);
+        CHECK_EQUAL((cl_context_properties)m_platform, props_ret[idx_ret++]);
       }
+
+      CHECK_EQUAL(0, props_ret[idx_ret++]);
+      CHECK_EQUAL(idx, idx_ret);
+
+      syncThreads();
+      ACL_LOCKED(acl_print_debug_msg(" Releaseing context\n"));
+      clReleaseContext(context);
+      syncThreads();
+      CHECK_EQUAL(0, acl_get_num_alloc_cl_context());
+      syncThreads();
     }
   }