Fix deprecation warning in CacheAllocator

Author: vinser52

cachelib/allocator/CacheAllocator-inl.h

@@ -1281,7 +1281,7 @@ CacheAllocator<CacheTrait>::moveRegularItemWithSync(
     // should be fine for it to be left in an inconsistent state.
     config_.moveCb(oldItem, *newItemHdl, nullptr);
   } else {
-    std::memcpy(newItemHdl->getWritableMemory(), oldItem.getMemory(),
+    std::memcpy(newItemHdl->getMemory(), oldItem.getMemory(),
                 oldItem.getSize());
   }
 

cachelib/allocator/tests/BaseAllocatorTest.h

@@ -6073,7 +6073,7 @@ class BaseAllocatorTest : public AllocatorTest<AllocatorT> {
 
     std::set<std::string> movedKeys;
     auto moveCb = [&](const Item& oldItem, Item& newItem, Item* /* parentPtr */) {
-      std::memcpy(newItem.getWritableMemory(), oldItem.getMemory(), oldItem.getSize());
+      std::memcpy(newItem.getMemory(), oldItem.getMemory(), oldItem.getSize());
       movedKeys.insert(oldItem.getKey().str());
     };
 
@@ -6103,7 +6103,7 @@ class BaseAllocatorTest : public AllocatorTest<AllocatorT> {
       auto h = alloc.allocate(pid, key, 1024);
       EXPECT_TRUE(h);
 
-      std::memcpy(h->getWritableMemory(), data.data(), data.size());
+      std::memcpy(h->getMemory(), data.data(), data.size());
 
       alloc.insertOrReplace(h);
     }