Skip to content

Commit 7c53f57

Browse files
igchorbyrnedj
authored andcommitted
Remove parameter for markMoving()
1 parent 5733d49 commit 7c53f57

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

cachelib/allocator/CacheAllocator-inl.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1386,7 +1386,6 @@ bool CacheAllocator<CacheTrait>::moveRegularItemWithSync(
13861386
oldItem.getSize());
13871387
}
13881388

1389-
13901389
// Adding the item to mmContainer has to succeed since no one can remove the item
13911390
auto& newContainer = getMMContainer(*newItemHdl);
13921391
auto mmContainerAdded = newContainer.add(*newItemHdl);
@@ -3661,8 +3660,6 @@ bool CacheAllocator<CacheTrait>::markMovingForSlabRelease(
36613660
// Since this callback is executed, the item is not yet freed
36623661
itemFreed = false;
36633662
Item* item = static_cast<Item*>(memory);
3664-
// TODO: for chained items, moving bit is only used to avoid
3665-
// freeing the item prematurely
36663663
if (item->markMoving()) {
36673664
markedMoving = true;
36683665
}

0 commit comments

Comments
 (0)