feat(client lib): add missing Dummy re-export
#2737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow usage without needing an import of common. Note: reexport of `fake_data` and `fake_keys` were considered as well but were discarded in order to maintain ability to changes them easily without having to worry about breaking `mithril-client` library. This problem is less relevant for the `Dummy` trait as it's really simple and don't risk to change anytime soon.
* mithril-client-cli from `0.12.31` to `0.12.32` * mithril-client from `0.12.31` to `0.12.32`
Alenar
force-pushed
the
djo/fix/client-lib/missing-reexport
branch
from
77cc757 to
7ca4c89
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR make the
mithril-clientlibrary re-export themithril_common::test::double::Dummytrait, allowing third party to use it in their tests.Note
Re-export of
fake_dataandfake_keyswere considered as well, but were discarded in order to maintain ability to changes them easily without having to worry about breaking themithril-clientlibrary.This problem is less relevant for the
Dummytrait as it's really simple and don't risk to change anytime soon.Pre-submit checklist