Skip to content

Conversation

@turmelclem
Copy link
Collaborator

@turmelclem turmelclem commented Oct 8, 2025

Content

  • fix AggregatorCapabilities struct with a default value to ensure backward compatibility
  • fix E2E test backward compatibility by putting back the version of backend cardano-db used to avoid default version mecanism

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

Closes #2730

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results

    4 files  ±0    164 suites  ±0   23m 54s ⏱️ -7s
2 195 tests ±0  2 195 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 760 runs  ±0  6 760 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0a8945f. ± Comparison against base commit d7ce977.

♻️ This comment has been updated with latest results.

@turmelclem turmelclem changed the title put back the version of backend cardano-db used to avoid default mecanism Fix retro compatibilty issues Oct 8, 2025
@turmelclem turmelclem changed the title Fix retro compatibilty issues Fix backward compatibilty issues Oct 8, 2025
@turmelclem turmelclem requested review from Alenar and jpraynaud October 8, 2025 13:15
* mithril-common from `0.6.20` to `0.6.21`
* mithril-end-to-end from `0.4.104` to `0.4.105`
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@turmelclem turmelclem marked this pull request as ready for review October 8, 2025 13:33
@turmelclem turmelclem merged commit c79713d into main Oct 8, 2025
41 checks passed
@turmelclem turmelclem deleted the ctl/2730-fix-backward-compatibility-test-backend-v2 branch October 8, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backward compatibility with latest release is broken

4 participants