Skip to content

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Oct 7, 2025

Content

This PR includes a fix for the DMQ integration tests flakiness which was due to non deterministic timestamp provider when signing DMQ messages with KES keys.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #2728

@jpraynaud jpraynaud self-assigned this Oct 7, 2025
@jpraynaud jpraynaud force-pushed the jpraynaud/2728-fix-flakiness-dmq-tests branch from d34db51 to 4daedb0 Compare October 7, 2025 15:58
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Test Results

    4 files  ±0    164 suites  ±0   23m 50s ⏱️ -11s
2 195 tests ±0  2 195 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 760 runs  ±0  6 760 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a26d829. ± Comparison against base commit d7ce977.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/2728-fix-flakiness-dmq-tests branch from 4daedb0 to a26d829 Compare October 7, 2025 16:07
@jpraynaud jpraynaud requested a review from Copilot October 7, 2025 17:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes flakiness in DMQ (Decentralized Message Queue) integration tests by implementing deterministic timestamp handling for KES key message signing.

  • Introduces a FakeUnixTimestampProvider test double for deterministic timestamp generation
  • Updates DMQ message builders in tests to use the fake timestamp provider
  • Version bump from 0.1.11 to 0.1.12

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/mithril-dmq/src/test/double/timestamp.rs New fake timestamp provider implementation for testing
internal/mithril-dmq/src/test/double/mod.rs Module exports for the new timestamp test double
internal/mithril-dmq/src/test/fake_message.rs Updated to use deterministic timestamp provider
internal/mithril-dmq/tests/publisher_client_server.rs Integration test updated to use fake timestamp provider
internal/mithril-dmq/Cargo.toml Version bump to 0.1.12

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jpraynaud jpraynaud requested review from Alenar and turmelclem October 7, 2025 17:08
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@turmelclem turmelclem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud merged commit 9f90c66 into main Oct 8, 2025
41 of 43 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2728-fix-flakiness-dmq-tests branch October 8, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DMQ integration tests are flaky in CI

4 participants