-
Notifications
You must be signed in to change notification settings - Fork 52
fix: flakiness in DMQ integration tests in CI #2729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d34db51 to
4daedb0
Compare
* mithril-dmq from `0.1.11` to `0.1.12`
4daedb0 to
a26d829
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes flakiness in DMQ (Decentralized Message Queue) integration tests by implementing deterministic timestamp handling for KES key message signing.
- Introduces a
FakeUnixTimestampProvidertest double for deterministic timestamp generation - Updates DMQ message builders in tests to use the fake timestamp provider
- Version bump from 0.1.11 to 0.1.12
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
internal/mithril-dmq/src/test/double/timestamp.rs |
New fake timestamp provider implementation for testing |
internal/mithril-dmq/src/test/double/mod.rs |
Module exports for the new timestamp test double |
internal/mithril-dmq/src/test/fake_message.rs |
Updated to use deterministic timestamp provider |
internal/mithril-dmq/tests/publisher_client_server.rs |
Integration test updated to use fake timestamp provider |
internal/mithril-dmq/Cargo.toml |
Version bump to 0.1.12 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Alenar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
turmelclem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Content
This PR includes a fix for the DMQ integration tests flakiness which was due to non deterministic timestamp provider when signing DMQ messages with KES keys.
Pre-submit checklist
Issue(s)
Closes #2728