Skip to content

Conversation

@turmelclem
Copy link
Collaborator

@turmelclem turmelclem commented Sep 29, 2025

Content

The default version used for the client-CLI command cardano-db is now v2.

This PR includes...

  • make cardano-db with version 2 as default ;
  • update documentation with updated cardano-db v2 examples ;
  • adapt Aggregator stress test to use v2 endpoints, and signed entity type CardanoDatabase instead of ImmutableFilesFull
  • update the CI (test-client.yml) to :
    • remove optional --backend v2 from cardano-db calls ;
    • add --backend v1 when no version was specified.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Closes #2701

@turmelclem turmelclem self-assigned this Sep 29, 2025
@github-actions
Copy link

github-actions bot commented Sep 29, 2025

Test Results

    4 files  ±0    164 suites  ±0   23m 47s ⏱️ +12s
2 182 tests ±0  2 182 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 709 runs  ±0  6 709 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 45ff226. ± Comparison against base commit 67b18cd.

♻️ This comment has been updated with latest results.

* mithril-client-cli from `0.12.30` to `0.12.31`
* mithril-end-to-end from `0.4.102` to `0.4.103`
@turmelclem turmelclem force-pushed the ctl/2701-make-cardano-db-backend-v2-default branch from f51961e to 45ff226 Compare September 30, 2025 07:55
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@turmelclem turmelclem marked this pull request as ready for review September 30, 2025 08:27
@turmelclem turmelclem merged commit 0df5853 into main Sep 30, 2025
100 of 102 checks passed
@turmelclem turmelclem deleted the ctl/2701-make-cardano-db-backend-v2-default branch September 30, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize Cardano DB v2 client CLI/library - Phase 3

3 participants