Skip to content

Conversation

@Alenar
Copy link
Collaborator

@Alenar Alenar commented Jul 25, 2025

Content

This PR fix a compilation issue with mithril-metric introduced by the merge of #2650.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • No new TODOs introduced

Issue(s)

Relates to #2580

@Alenar Alenar self-assigned this Jul 25, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a compilation issue in the mithril-metric crate tests that was introduced by merge #2650. The fix involves adding a missing test dependency and updating the crate version.

  • Added missing mithril-common dependency with test_tools feature for dev dependencies
  • Updated crate version from 0.1.17 to 0.1.18

Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

Test Results

    4 files  ±0    154 suites  ±0   23m 21s ⏱️ +2s
2 118 tests ±0  2 118 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 466 runs  ±0  6 466 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f7315a3. ± Comparison against base commit 2ab36d3.

@Alenar Alenar temporarily deployed to testing-preview July 25, 2025 15:42 — with GitHub Actions Inactive
Copy link
Collaborator

@turmelclem turmelclem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@Alenar Alenar merged commit 0122f3e into main Jul 28, 2025
41 checks passed
@Alenar Alenar deleted the djo/2580/fix-mithril-metric-tests branch July 28, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants