Skip to content

chore: replace serde_yaml with serde_yml #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

chore: replace serde_yaml with serde_yml #2649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a788ca
chore: replace `serde_yaml` with `serde_yml` in `mithril-build-script…
dlachaume Jul 23, 2025
1ec2bbf
chore: upgrade crate versions
dlachaume Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions internal/mithril-build-script/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "mithril-build-script"
version = "0.2.25"
version = "0.2.26"
description = "A toolbox for Mithril crates build scripts"
authors = { workspace = true }
edition = { workspace = true }
Expand All @@ -12,4 +12,4 @@ include = ["**/*.rs", "Cargo.toml", "README.md", ".gitignore"]
[dependencies]
semver = { workspace = true }
serde_json = { workspace = true }
serde_yaml = "0.9.34"
serde_yml = "0.0.12"
2 changes: 1 addition & 1 deletion internal/mithril-build-script/src/open_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ pub fn list_all_open_api_spec_files(paths: &[&Path]) -> Vec<PathBuf> {

fn read_version_from_open_api_spec_file<P: AsRef<Path>>(spec_file_path: P) -> OpenAPIVersionRaw {
let yaml_spec = fs::read_to_string(spec_file_path).unwrap();
let open_api: serde_yaml::Value = serde_yaml::from_str(&yaml_spec).unwrap();
let open_api: serde_yml::Value = serde_yml::from_str(&yaml_spec).unwrap();
open_api["info"]["version"].as_str().unwrap().to_owned()
}

Expand Down
4 changes: 2 additions & 2 deletions internal/tests/mithril-api-spec/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "mithril-api-spec"
version = "0.1.2"
version = "0.1.3"
authors.workspace = true
documentation.workspace = true
edition.workspace = true
Expand All @@ -13,7 +13,7 @@ jsonschema = { version = "0.30.0" }
reqwest = { workspace = true }
serde = { workspace = true }
serde_json = { workspace = true }
serde_yaml = { version = "0.9.34" }
serde_yml = "0.0.12"
warp = { workspace = true }

[dev-dependencies]
Expand Down
2 changes: 1 addition & 1 deletion internal/tests/mithril-api-spec/src/apispec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ impl<'a> APISpec<'a> {
/// APISpec factory from spec
pub fn from_file(path: &str) -> APISpec<'a> {
let yaml_spec = std::fs::read_to_string(path).unwrap();
let openapi: serde_json::Value = serde_yaml::from_str(&yaml_spec).unwrap();
let openapi: serde_json::Value = serde_yml::from_str(&yaml_spec).unwrap();
APISpec {
openapi,
path: None,
Expand Down
Loading